GNU bug report logs - #76137
[PATCH] Eliminate bookmark-maybe-historicize-string duplicates

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76137: closed ([PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates)
Date: Tue, 11 Feb 2025 07:49:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Feb 2025 23:48:23 -0800
with message-id <CADwFkmmrgRbW3CGLt3yiuAFW2avsf6Fyw47bHe3yM9=rynw8hg <at> mail.gmail.com>
and subject line Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string duplicates
has caused the debbugs.gnu.org bug report #76137,
regarding [PATCH] Eliminate bookmark-maybe-historicize-string duplicates
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76137: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76137
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eliminate bookmark-maybe-historicize-string duplicates
Date: Fri, 7 Feb 2025 19:49:39 -0500

[Message part 3 (text/plain, inline)]

Change 'bookmark-maybe-historicize-string' from its naive history list
cons, which blindly adds duplicates ad infinitum, to use 'add-to-history'
which respects 'history-delete-duplicates' and the 'history-length
property (which 'bookmark-history' currently does not have).

-Stephane

[Message part 4 (text/html, inline)]

[0001-Eliminate-bookmark-maybe-historicize-string-duplicat.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76137-done <at> debbugs.gnu.org
Subject: Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates
Date: Mon, 10 Feb 2025 23:48:23 -0800

Version: 31.1

Ship Mints <shipmints <at> gmail.com> writes:

> And now revised with NEWS.
>
> On Fri, Feb 7, 2025 at 7:58 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Revised patch with bookmark-history dupe test.
>
>  On Fri, Feb 7, 2025 at 7:53 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Maybe I'll fix the bookmark test that currently doesn't check for duplicates. Hrumph.
>
>  On Fri, Feb 7, 2025 at 7:51 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Change 'bookmark-maybe-historicize-string' from its naive history list cons, which
>  blindly adds duplicates ad infinitum, to use 'add-to-history' which respects
>  'history-delete-duplicates' and the 'history-length property (which 'bookmark-history'
>  currently does not have).
>
>  -Stephane

Thanks, installed on master as commit 788380cf6a2.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.