GNU bug report logs - #76137
[PATCH] Eliminate bookmark-maybe-historicize-string duplicates

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76137 in the body.
You can then email your comments to 76137 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eliminate bookmark-maybe-historicize-string duplicates
Date: Fri, 7 Feb 2025 19:49:39 -0500

[Message part 1 (text/plain, inline)]

Change 'bookmark-maybe-historicize-string' from its naive history list
cons, which blindly adds duplicates ad infinitum, to use 'add-to-history'
which respects 'history-delete-duplicates' and the 'history-length
property (which 'bookmark-history' currently does not have).

-Stephane

[Message part 2 (text/html, inline)]

[0001-Eliminate-bookmark-maybe-historicize-string-duplicat.patch (application/octet-stream, attachment)]

Message #8 received at 76137 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: 76137 <at> debbugs.gnu.org
Subject: Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates
Date: Fri, 7 Feb 2025 19:53:09 -0500

[Message part 1 (text/plain, inline)]

Maybe I'll fix the bookmark test that currently doesn't check for
duplicates. Hrumph.

On Fri, Feb 7, 2025 at 7:51 PM Ship Mints <shipmints <at> gmail.com> wrote:

> Change 'bookmark-maybe-historicize-string' from its naive history list
> cons, which blindly adds duplicates ad infinitum, to use 'add-to-history'
> which respects 'history-delete-duplicates' and the 'history-length
> property (which 'bookmark-history' currently does not have).
>
> -Stephane
>

[Message part 2 (text/html, inline)]

Message #11 received at 76137 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: 76137 <at> debbugs.gnu.org
Subject: Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates
Date: Fri, 7 Feb 2025 19:58:48 -0500

[Message part 1 (text/plain, inline)]

Revised patch with bookmark-history dupe test.

On Fri, Feb 7, 2025 at 7:53 PM Ship Mints <shipmints <at> gmail.com> wrote:

> Maybe I'll fix the bookmark test that currently doesn't check for
> duplicates. Hrumph.
>
> On Fri, Feb 7, 2025 at 7:51 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>> Change 'bookmark-maybe-historicize-string' from its naive history list
>> cons, which blindly adds duplicates ad infinitum, to use 'add-to-history'
>> which respects 'history-delete-duplicates' and the 'history-length
>> property (which 'bookmark-history' currently does not have).
>>
>> -Stephane
>>
>

[Message part 2 (text/html, inline)]

[0001-Eliminate-bookmark-maybe-historicize-string-duplicat.patch (application/octet-stream, attachment)]

Message #14 received at 76137 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: 76137 <at> debbugs.gnu.org
Subject: Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates
Date: Sat, 8 Feb 2025 05:48:18 -0500

[Message part 1 (text/plain, inline)]

And now revised with NEWS.

On Fri, Feb 7, 2025 at 7:58 PM Ship Mints <shipmints <at> gmail.com> wrote:

> Revised patch with bookmark-history dupe test.
>
> On Fri, Feb 7, 2025 at 7:53 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>> Maybe I'll fix the bookmark test that currently doesn't check for
>> duplicates. Hrumph.
>>
>> On Fri, Feb 7, 2025 at 7:51 PM Ship Mints <shipmints <at> gmail.com> wrote:
>>
>>> Change 'bookmark-maybe-historicize-string' from its naive history list
>>> cons, which blindly adds duplicates ad infinitum, to use 'add-to-history'
>>> which respects 'history-delete-duplicates' and the 'history-length
>>> property (which 'bookmark-history' currently does not have).
>>>
>>> -Stephane
>>>
>>

[Message part 2 (text/html, inline)]

[0001-Eliminate-bookmark-maybe-historicize-string-duplicat.patch (application/octet-stream, attachment)]

Message #21 received at 76137-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76137-done <at> debbugs.gnu.org
Subject: Re: bug#76137: [PATCH] Eliminate bookmark-maybe-historicize-string
 duplicates
Date: Mon, 10 Feb 2025 23:48:23 -0800

Version: 31.1

Ship Mints <shipmints <at> gmail.com> writes:

> And now revised with NEWS.
>
> On Fri, Feb 7, 2025 at 7:58 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Revised patch with bookmark-history dupe test.
>
>  On Fri, Feb 7, 2025 at 7:53 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Maybe I'll fix the bookmark test that currently doesn't check for duplicates. Hrumph.
>
>  On Fri, Feb 7, 2025 at 7:51 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Change 'bookmark-maybe-historicize-string' from its naive history list cons, which
>  blindly adds duplicates ad infinitum, to use 'add-to-history' which respects
>  'history-delete-duplicates' and the 'history-length property (which 'bookmark-history'
>  currently does not have).
>
>  -Stephane

Thanks, installed on master as commit 788380cf6a2.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.