GNU bug report logs - #76138
[PATCH] gnu: emacs-stgit: Fix install location.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76138 in the body.
You can then email your comments to 76138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: emacs-stgit: Fix install location.
Date: Fri,  7 Feb 2025 21:41:37 -0500

* gnu/packages/version-control.scm (emacs-stgit): Previously the files got
installed under a "contrib" sub-directory that does not work with our Emacs
configuration.  This fixes that.

Change-Id: Ic7c237476fd18f73dbfbde3368ceae4962ba9634
---
 gnu/packages/version-control.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 6e139e75d4..bc99d6bdfd 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2123,7 +2123,12 @@ (define-public emacs-stgit
     (name "emacs-stgit")
     (build-system emacs-build-system)
     (arguments
-     (list #:include '(list "contrib/stgit.el")))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'enter-lisp-directory
+            (lambda _
+              (chdir "contrib"))))))
     (synopsis "Emacs major mode for StGit interaction")
     (description "This package a interactive tool to interact with git
 branches using StGit.")
-- 
2.48.1

Message #8 received at 76138 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 76138 <at> debbugs.gnu.org
Subject: Re: [bug#76138] [PATCH] gnu: emacs-stgit: Fix install location.
Date: Sat, 08 Feb 2025 17:32:37 -0800

Hi Morgan,

Morgan Smith <Morgan.J.Smith <at> outlook.com> writes:

> * gnu/packages/version-control.scm (emacs-stgit): Previously the 
> files got
> installed under a "contrib" sub-directory that does not work 
> with our Emacs
> configuration.  This fixes that.
>

This part of the patch looks good, but I noticed that the 
/usr/share/doc directory (which contains the license) is no longer 
included.  Could you send a v2 which restores it, please?

Thanks,
 -- Ian

Message #11 received at 76138 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: ian <at> retrospec.tv
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 76138 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: emacs-stgit: Fix install location.
Date: Sun,  9 Feb 2025 18:32:11 -0500

* gnu/packages/version-control.scm (emacs-stgit): Previously the files got
installed under a "contrib" sub-directory that does not work with our Emacs
configuration.  This fixes that.

Change-Id: Ic7c237476fd18f73dbfbde3368ceae4962ba9634
---
 gnu/packages/version-control.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 6e139e75d4..fc1ccdca38 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2123,7 +2123,15 @@ (define-public emacs-stgit
     (name "emacs-stgit")
     (build-system emacs-build-system)
     (arguments
-     (list #:include '(list "contrib/stgit.el")))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'enter-lisp-directory
+            (lambda _
+              (chdir "contrib")))
+          (add-before 'install-license-files 'leave-lisp-directory
+            (lambda _
+              (chdir ".."))))))
     (synopsis "Emacs major mode for StGit interaction")
     (description "This package a interactive tool to interact with git
 branches using StGit.")
-- 
2.48.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.