GNU bug report logs - #75837
[PATCH] Add autosave timer to save-place in harmony with savehist

Previous Next

Full log

Message #11 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 1 Feb 2025 08:15:31 -0500

[Message part 1 (text/plain, inline)]

Thank you for the review. Revised patch attached.

On Sat, Feb 1, 2025 at 6:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Sat, 25 Jan 2025 14:26:40 -0500
> >
> > * lisp/saveplace.el (save-place-autosave-interval):
> > Add supporting functions for save-place autosave idle timer.
> >
> > I have a private implementation of this that I rely on that other people
> might find helpful as a builtin.
>
> Thanks, a few comments below.
>
> > * lisp/saveplace.el (save-place-autosave-interval):
> > Add supporting functions for save-place autosave idle timer.
>
> This log message is incomplete.  Please mention all the changes in all
> the functions/variables.
>
> > +(defcustom save-place-autosave-interval (* 5 60)
> > +  "The interval between autosaves of buffer places.
> > +If set to nil, disables timer-based autosaving.
> > +Use `setopt' or Customize commands to set this option."
> > +  :type '(choice (const :tag "Disabled" nil)
> > +                 (integer :tag "Seconds"))
> > +  :version "31.1"
>
> Why should we turn this on by default?  I think it should be disabled
> by default.
>
> Finally, this needs a NEWS entry.
>

[Message part 2 (text/html, inline)]

[0001-Add-auto-save-timer-to-save-place-bug-75837.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.