GNU bug report logs - #75836
shepherd: cron-string->calendar-event does not seem to work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75836 in the body.
You can then email your comments to 75836 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: bug-guix <at> gnu.org
Subject: shepherd: cron-string->calendar-event does not seem to work
Date: Sat, 25 Jan 2025 20:06:49 +0100

[Message part 1 (text/plain, inline)]

Five asterisks (* * * * *) is a valid cron time specification, but
cron-string->calendar-event chokes one it:

--8<---------------cut here---------------start------------->8---
$ guix shell guile shepherd guile-fibers -- guile -c '(use-modules (shepherd service timer)) (cron-string->calendar-event "* * * * *")'
Backtrace:
In ice-9/boot-9.scm:
  1752:10  7 (with-exception-handler _ _ #:unwind? _ # _)
In unknown file:
           6 (apply-smob/0 #<thunk 7f8d870d7300>)
In ice-9/boot-9.scm:
    724:2  5 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8  4 (_ #(#(#<directory (guile-user) 7f8d870dac80>)))
In ice-9/command-line.scm:
   185:19  3 (_ #<input: string 7f8d870d4850>)
In unknown file:
           2 (eval (cron-string->calendar-event "* * * * *") #<direc…>)
In shepherd/service/timer.scm:
    155:2  1 (calendar-event #:seconds _ #:minutes _ #:hours _ # _ # …)
In srfi/srfi-1.scm:
    634:9  0 (for-each #<procedure 7f8d7f382a80 at shepherd/service…> …)

srfi/srfi-1.scm:634:9: In procedure for-each:
ERROR:
  1. &message: "calendar-event: hours: 24: value out of range (0-23)"
--8<---------------cut here---------------end--------------->8---

I *think* on line 450 in timer.scm there should be `(hours 24 0)'
instead of the current `(hours 60 0)'.

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 75836-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 75836-done <at> debbugs.gnu.org
Subject: Re: bug#75836: shepherd: cron-string->calendar-event does not seem
 to work
Date: Wed, 05 Feb 2025 15:25:47 +0100

Hello,

Tomas Volf <~@wolfsden.cz> skribis:

> $ guix shell guile shepherd guile-fibers -- guile -c '(use-modules (shepherd service timer)) (cron-string->calendar-event "* * * * *")'

[...]

>   1. &message: "calendar-event: hours: 24: value out of range (0-23)"
>
> I *think* on line 450 in timer.scm there should be `(hours 24 0)'
> instead of the current `(hours 60 0)'.

Indeed.  Fixed in Shepherd commit
e23044715b14dae3158926a49b771fd5862d65db.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.