GNU bug report logs - #75837
[PATCH] Add autosave timer to save-place in harmony with savehist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75837 in the body.
You can then email your comments to 75837 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add autosave timer to save-place in harmony with savehist
Date: Sat, 25 Jan 2025 14:26:40 -0500

[Message part 1 (text/plain, inline)]

* lisp/saveplace.el (save-place-autosave-interval):
Add supporting functions for save-place autosave idle timer.

I have a private implementation of this that I rely on that other people
might find helpful as a builtin.

-Stephane

[Message part 2 (text/html, inline)]

[0001-Add-autosave-timer-to-save-place-in-harmony-with-sav.patch (application/octet-stream, attachment)]

Message #8 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 01 Feb 2025 13:06:14 +0200

> From: Ship Mints <shipmints <at> gmail.com>
> Date: Sat, 25 Jan 2025 14:26:40 -0500
> 
> * lisp/saveplace.el (save-place-autosave-interval):
> Add supporting functions for save-place autosave idle timer.
> 
> I have a private implementation of this that I rely on that other people might find helpful as a builtin.

Thanks, a few comments below.

> * lisp/saveplace.el (save-place-autosave-interval):
> Add supporting functions for save-place autosave idle timer.

This log message is incomplete.  Please mention all the changes in all
the functions/variables.

> +(defcustom save-place-autosave-interval (* 5 60)
> +  "The interval between autosaves of buffer places.
> +If set to nil, disables timer-based autosaving.
> +Use `setopt' or Customize commands to set this option."
> +  :type '(choice (const :tag "Disabled" nil)
> +                 (integer :tag "Seconds"))
> +  :version "31.1"

Why should we turn this on by default?  I think it should be disabled
by default.

Finally, this needs a NEWS entry.

Message #11 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 1 Feb 2025 08:15:31 -0500

[Message part 1 (text/plain, inline)]

Thank you for the review. Revised patch attached.

On Sat, Feb 1, 2025 at 6:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Sat, 25 Jan 2025 14:26:40 -0500
> >
> > * lisp/saveplace.el (save-place-autosave-interval):
> > Add supporting functions for save-place autosave idle timer.
> >
> > I have a private implementation of this that I rely on that other people
> might find helpful as a builtin.
>
> Thanks, a few comments below.
>
> > * lisp/saveplace.el (save-place-autosave-interval):
> > Add supporting functions for save-place autosave idle timer.
>
> This log message is incomplete.  Please mention all the changes in all
> the functions/variables.
>
> > +(defcustom save-place-autosave-interval (* 5 60)
> > +  "The interval between autosaves of buffer places.
> > +If set to nil, disables timer-based autosaving.
> > +Use `setopt' or Customize commands to set this option."
> > +  :type '(choice (const :tag "Disabled" nil)
> > +                 (integer :tag "Seconds"))
> > +  :version "31.1"
>
> Why should we turn this on by default?  I think it should be disabled
> by default.
>
> Finally, this needs a NEWS entry.
>

[Message part 2 (text/html, inline)]

[0001-Add-auto-save-timer-to-save-place-bug-75837.patch (application/octet-stream, attachment)]

Message #14 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 1 Feb 2025 09:22:20 -0500

[Message part 1 (text/plain, inline)]

I need to go back and double space those sentences. My attempt to automate
didn't work. Gimme a minute.

On Sat, Feb 1, 2025 at 8:15 AM Ship Mints <shipmints <at> gmail.com> wrote:

> Thank you for the review. Revised patch attached.
>
> On Sat, Feb 1, 2025 at 6:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > From: Ship Mints <shipmints <at> gmail.com>
>> > Date: Sat, 25 Jan 2025 14:26:40 -0500
>> >
>> > * lisp/saveplace.el (save-place-autosave-interval):
>> > Add supporting functions for save-place autosave idle timer.
>> >
>> > I have a private implementation of this that I rely on that other
>> people might find helpful as a builtin.
>>
>> Thanks, a few comments below.
>>
>> > * lisp/saveplace.el (save-place-autosave-interval):
>> > Add supporting functions for save-place autosave idle timer.
>>
>> This log message is incomplete.  Please mention all the changes in all
>> the functions/variables.
>>
>> > +(defcustom save-place-autosave-interval (* 5 60)
>> > +  "The interval between autosaves of buffer places.
>> > +If set to nil, disables timer-based autosaving.
>> > +Use `setopt' or Customize commands to set this option."
>> > +  :type '(choice (const :tag "Disabled" nil)
>> > +                 (integer :tag "Seconds"))
>> > +  :version "31.1"
>>
>> Why should we turn this on by default?  I think it should be disabled
>> by default.
>>
>> Finally, this needs a NEWS entry.
>>
>

[Message part 2 (text/html, inline)]

Message #17 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 1 Feb 2025 09:25:32 -0500

[Message part 1 (text/plain, inline)]

I'll wait on this until we settle the timer discussion.

On Sat, Feb 1, 2025 at 9:22 AM Ship Mints <shipmints <at> gmail.com> wrote:

> I need to go back and double space those sentences. My attempt to automate
> didn't work. Gimme a minute.
>
> On Sat, Feb 1, 2025 at 8:15 AM Ship Mints <shipmints <at> gmail.com> wrote:
>
>> Thank you for the review. Revised patch attached.
>>
>> On Sat, Feb 1, 2025 at 6:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> > From: Ship Mints <shipmints <at> gmail.com>
>>> > Date: Sat, 25 Jan 2025 14:26:40 -0500
>>> >
>>> > * lisp/saveplace.el (save-place-autosave-interval):
>>> > Add supporting functions for save-place autosave idle timer.
>>> >
>>> > I have a private implementation of this that I rely on that other
>>> people might find helpful as a builtin.
>>>
>>> Thanks, a few comments below.
>>>
>>> > * lisp/saveplace.el (save-place-autosave-interval):
>>> > Add supporting functions for save-place autosave idle timer.
>>>
>>> This log message is incomplete.  Please mention all the changes in all
>>> the functions/variables.
>>>
>>> > +(defcustom save-place-autosave-interval (* 5 60)
>>> > +  "The interval between autosaves of buffer places.
>>> > +If set to nil, disables timer-based autosaving.
>>> > +Use `setopt' or Customize commands to set this option."
>>> > +  :type '(choice (const :tag "Disabled" nil)
>>> > +                 (integer :tag "Seconds"))
>>> > +  :version "31.1"
>>>
>>> Why should we turn this on by default?  I think it should be disabled
>>> by default.
>>>
>>> Finally, this needs a NEWS entry.
>>>
>>

[Message part 2 (text/html, inline)]

Message #20 received at 75837 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75837 <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 1 Feb 2025 10:01:14 -0500

[Message part 1 (text/plain, inline)]

Regular timer and, I hope proper formatting, etc. I've included the bug
number in the commit log.

On Sat, Feb 1, 2025 at 9:25 AM Ship Mints <shipmints <at> gmail.com> wrote:

> I'll wait on this until we settle the timer discussion.
>
> On Sat, Feb 1, 2025 at 9:22 AM Ship Mints <shipmints <at> gmail.com> wrote:
>
>> I need to go back and double space those sentences. My attempt to
>> automate didn't work. Gimme a minute.
>>
>> On Sat, Feb 1, 2025 at 8:15 AM Ship Mints <shipmints <at> gmail.com> wrote:
>>
>>> Thank you for the review. Revised patch attached.
>>>
>>> On Sat, Feb 1, 2025 at 6:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>>>
>>>> > From: Ship Mints <shipmints <at> gmail.com>
>>>> > Date: Sat, 25 Jan 2025 14:26:40 -0500
>>>> >
>>>> > * lisp/saveplace.el (save-place-autosave-interval):
>>>> > Add supporting functions for save-place autosave idle timer.
>>>> >
>>>> > I have a private implementation of this that I rely on that other
>>>> people might find helpful as a builtin.
>>>>
>>>> Thanks, a few comments below.
>>>>
>>>> > * lisp/saveplace.el (save-place-autosave-interval):
>>>> > Add supporting functions for save-place autosave idle timer.
>>>>
>>>> This log message is incomplete.  Please mention all the changes in all
>>>> the functions/variables.
>>>>
>>>> > +(defcustom save-place-autosave-interval (* 5 60)
>>>> > +  "The interval between autosaves of buffer places.
>>>> > +If set to nil, disables timer-based autosaving.
>>>> > +Use `setopt' or Customize commands to set this option."
>>>> > +  :type '(choice (const :tag "Disabled" nil)
>>>> > +                 (integer :tag "Seconds"))
>>>> > +  :version "31.1"
>>>>
>>>> Why should we turn this on by default?  I think it should be disabled
>>>> by default.
>>>>
>>>> Finally, this needs a NEWS entry.
>>>>
>>>

[Message part 2 (text/html, inline)]

[0001-Add-auto-save-timer-to-save-place-bug-75837.patch (application/octet-stream, attachment)]

Message #25 received at 75837-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 75837-done <at> debbugs.gnu.org
Subject: Re: bug#75837: [PATCH] Add autosave timer to save-place in harmony
 with savehist
Date: Sat, 01 Feb 2025 22:02:38 +0200

> From: Ship Mints <shipmints <at> gmail.com>
> Date: Sat, 1 Feb 2025 10:01:14 -0500
> Cc: 75837 <at> debbugs.gnu.org
> 
> Regular timer and, I hope proper formatting, etc. I've included the bug number in the commit log.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.