GNU bug report logs - #73937
[PATCH]: Update Nyxt to 3.12.0

Previous Next

Package: guix-patches;

Reported by: André A. Gomes <andremegafone <at> gmail.com>

Date: Mon, 21 Oct 2024 19:17:01 UTC

Severity: normal

Tags: moreinfo, patch

Merged with 72412

To reply to this bug, email your comments to 73937 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#73937; Package guix-patches. (Mon, 21 Oct 2024 19:17:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to André A. Gomes <andremegafone <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 21 Oct 2024 19:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: Update Nyxt to 3.12.0
Date: Mon, 21 Oct 2024 22:16:10 +0300
[Message part 1 (text/plain, inline)]
Hello Guix,

Attached, thanks.

Please note that I am one of the Nyxt developers.  The changes reflect
that fact that the Lisp dependencies are pinned as git submodules.  The
tests are temporarily disabled since they fail due to undocumented
exported symbols (which is unreasonable).  I only noticed it after the
release, but I'll fix it for the next release.


-- 
André A. Gomes
"You cannot even find the ruins..."
[0001-gnu-nyxt-Update-to-3.12.0.patch (text/x-diff, attachment)]

Merged 72412 73937. Request was from André A. Gomes <andremegafone <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 22 Oct 2024 10:02:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#73937; Package guix-patches. (Wed, 23 Oct 2024 12:04:02 GMT) Full text and rfc822 format available.

Message #10 received at 73937 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: 73937 <at> debbugs.gnu.org
Subject: Re: [bug#73937] [PATCH]: Update Nyxt to 3.12.0
Date: Wed, 23 Oct 2024 12:02:59 +0000
[Message part 1 (text/plain, inline)]
André A. Gomes <andremegafone <at> gmail.com> skribis:

> Hello Guix,
>
> Attached, thanks.
>
> Please note that I am one of the Nyxt developers.  The changes reflect
> that fact that the Lisp dependencies are pinned as git submodules.  The
> tests are temporarily disabled since they fail due to undocumented
> exported symbols (which is unreasonable).  I only noticed it after the
> release, but I'll fix it for the next release.

Hi.
We usually try to avoid taking libraries from git submodules unless the
software can't be made to compile with system libraries.
Can't Nyxt 3.12.0 work with the libraries packaged in Guix?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#73937; Package guix-patches. (Wed, 23 Oct 2024 12:35:02 GMT) Full text and rfc822 format available.

Message #13 received at 73937 <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 73937 <at> debbugs.gnu.org
Subject: Re: [bug#73937] [PATCH]: Update Nyxt to 3.12.0
Date: Wed, 23 Oct 2024 15:33:04 +0300
Guillaume Le Vaillant <glv <at> posteo.net> writes:

> André A. Gomes <andremegafone <at> gmail.com> skribis:
>
>> Hello Guix,
>>
>> Attached, thanks.
>>
>> Please note that I am one of the Nyxt developers.  The changes reflect
>> that fact that the Lisp dependencies are pinned as git submodules.  The
>> tests are temporarily disabled since they fail due to undocumented
>> exported symbols (which is unreasonable).  I only noticed it after the
>> release, but I'll fix it for the next release.
>
> Hi.
> We usually try to avoid taking libraries from git submodules unless the
> software can't be made to compile with system libraries.
> Can't Nyxt 3.12.0 work with the libraries packaged in Guix?

Nyxt pins Common Lisp libraries versions as to ensure everything works
as expected.  Concretely, there's an issue related to sbcl-alexandria
since the commit Guix is using breaks Nyxt's functionality (see [1]).

You may argue that a sbcl-alexandria variant could be defined (see [2]),
but it seems brittle from Nyxt's perspective and probably undesirable
from Guix's perspective.

All package managers are using the git submodules to build Nyxt,
including Nix.  From Nyxt's perspective, any build that won't use the
pinned CL libraries versions isn't Nyxt per se, but a custom build (or
perhaps a "variation" in Guix's parlance).

Happy to know your thoughts.

[1] https://github.com/atlas-engineer/nyxt/issues/3503
[2] https://github.com/aadcg/aadcg-guix-channel/blob/284a62f30b91642b08a66d02679611655d0bfb51/packages/aadcg-nyxt.scm#L20


-- 
André A. Gomes
"You cannot even find the ruins..."




Information forwarded to guix-patches <at> gnu.org:
bug#73937; Package guix-patches. (Wed, 23 Oct 2024 19:32:02 GMT) Full text and rfc822 format available.

Message #16 received at 73937 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: 73937 <at> debbugs.gnu.org
Subject: Re: [bug#73937] [PATCH]: Update Nyxt to 3.12.0
Date: Wed, 23 Oct 2024 19:31:03 +0000
[Message part 1 (text/plain, inline)]
André A. Gomes <andremegafone <at> gmail.com> skribis:

> Guillaume Le Vaillant <glv <at> posteo.net> writes:
>
>> Hi.
>> We usually try to avoid taking libraries from git submodules unless the
>> software can't be made to compile with system libraries.
>> Can't Nyxt 3.12.0 work with the libraries packaged in Guix?
>
> Nyxt pins Common Lisp libraries versions as to ensure everything works
> as expected.  Concretely, there's an issue related to sbcl-alexandria
> since the commit Guix is using breaks Nyxt's functionality (see [1]).
>
> You may argue that a sbcl-alexandria variant could be defined (see [2]),
> but it seems brittle from Nyxt's perspective and probably undesirable
> from Guix's perspective.
>
> All package managers are using the git submodules to build Nyxt,
> including Nix.  From Nyxt's perspective, any build that won't use the
> pinned CL libraries versions isn't Nyxt per se, but a custom build (or
> perhaps a "variation" in Guix's parlance).
>
> Happy to know your thoughts.
>
> [1] https://github.com/atlas-engineer/nyxt/issues/3503
> [2] https://github.com/aadcg/aadcg-guix-channel/blob/284a62f30b91642b08a66d02679611655d0bfb51/packages/aadcg-nyxt.scm#L20

If I understand correctly, the issue comes from the fact that the
read-stream-content-into-string function from recent versions of
alexandria doesn't accept an octet stream as argument instead of
a character stream anymore.

Wouldn't it be possible to replace

    (alexandria:read-stream-content-into-string connection)

by something like

    (map 'string
         #'code-char
         (alexandria:read-stream-content-into-byte-vector connection))

in Nyxt? If it works it would allow us to continue using the system
libraries (some of which might have patches to work well in Guix).
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#73937; Package guix-patches. (Fri, 06 Jun 2025 18:11:01 GMT) Full text and rfc822 format available.

Message #19 received at 73937 <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: 73937 <at> debbugs.gnu.org
Subject: RE: [PATCH]: Update Nyxt to 3.12.0
Date: Fri, 06 Jun 2025 11:02:43 -0700
I applied this patch to today's guix commit
d2d961b76a5be75cb715dd9445afd65f44da616f.

It built and tested successfully but, as with the current guix version of
nyxt (3.11.7), it did not successfully execute.  It appears to have the
same problem the current version has with lockup on the default/title
page.  It complains that the kernel isn't recent enough for Iris.  I'm
running on 6.14.9, so that seems unreasonable. 

I know nyxt ran well in guix a few months ago.  I hope a way can be
found to again get it running natively on guix.

Regards,
Frank Pursel




This bug report was last modified 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.