GNU bug report logs - #73936
[PATCH] gnu: Add tuner.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73936 in the body.
You can then email your comments to 73936 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ashish.is <at> lostca.se
To: guix-patches <at> gnu.org
Cc: Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: [PATCH] gnu: Add tuner.
Date: Mon, 21 Oct 2024 19:54:05 +0200

From: Ashish SHUKLA <ashish.is <at> lostca.se>

* gnu/packages/music.scm (tuner): New variable.

Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1
---
Hi,

This patch adds a package for the internet radio station player "tuner"[0].

References:
[0] https://github.com/louis77/tuner

Thanks!

 gnu/packages/music.scm | 57 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 9c1a617ca1..c70870bbb2 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2024 Parnikkapore <poomklao <at> yahoo.com>
 ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
 ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
+;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,6 +169,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages netpbm)
   #:use-module (gnu packages networking)
+  #:use-module (gnu packages pantheon)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
@@ -2924,6 +2926,61 @@ (define-public bristol
 is subjective.")
     (license license:gpl3+)))
 
+(define-public tuner
+  (package
+    (name "tuner")
+    (version "1.5.4")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/louis77/tuner")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256 (base32 "0svzngqhsdbmw6s07adilicdgs2v8yamzh7p7krj0z0552qsdnf6"))))
+    (build-system meson-build-system)
+    (native-inputs
+     `(("desktop-file-utils" ,desktop-file-utils)       ; update-desktop-database
+       ("gettext-minimal" ,gettext-minimal)
+       ("glib:bin" ,glib "bin")                         ; glib-compile-schemas
+       ; for org.gnome.system.proxy schema
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gtk:bin" ,gtk "bin")                           ; gtk-update-icon-cache
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (inputs
+      (list bash-minimal
+            glib
+            granite-6
+            gtk+
+            libgee
+            gstreamer
+            gst-plugins-base   ; for gstreamer 'playbin'
+            gst-plugins-good   ; for gstreamer 'scaletempo'
+            gst-plugins-bad
+            libsoup
+            json-glib-minimal))
+    (arguments
+      (list
+        #:glib-or-gtk? #t
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'skip-gtk-update-icon-cache
+              (lambda _
+                (substitute* "meson/post_install.py"
+                  (("gtk-update-icon-cache") (which "true"))
+                  (("update-desktop-database") (which "true")))))
+            (add-after 'install 'wrap-tuner
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out             (assoc-ref outputs "out"))
+                     (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                 (wrap-program (string-append out "/bin/com.github.louis77.tuner")
+                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
+    (home-page "https://github.com/louis77/tuner")
+    (synopsis "Application to discover and play internet radio stations")
+    (description "A minimalist radio station player to discover and
+listen to your favourite internet radio stations")
+    (license license:gpl3+)))
+
 (define-public tuxguitar
   (package
     (name "tuxguitar")

base-commit: 59b2a60d0041882d732e1766e28f0df5a1ef1ac1
-- 
2.47.0

Message #8 received at 73936 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ashish.is <at> lostca.se
Cc: 73936 <at> debbugs.gnu.org
Subject: Re: [bug#73936] [PATCH] gnu: Add tuner.
Date: Mon, 30 Dec 2024 00:00:51 +0100

Hi,

ashish.is <at> lostca.se skribis:

> From: Ashish SHUKLA <ashish.is <at> lostca.se>
>
> * gnu/packages/music.scm (tuner): New variable.
>
> Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1

It fell through the cracks…

> +    (native-inputs
> +     `(("desktop-file-utils" ,desktop-file-utils)       ; update-desktop-database
> +       ("gettext-minimal" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin")                         ; glib-compile-schemas
> +       ; for org.gnome.system.proxy schema
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gtk:bin" ,gtk "bin")                           ; gtk-update-icon-cache
> +       ("pkg-config" ,pkg-config)
> +       ("vala" ,vala)))

Could you remove input labels (‘guix style -S inputs’)?

> +    (home-page "https://github.com/louis77/tuner")
> +    (synopsis "Application to discover and play internet radio stations")
> +    (description "A minimalist radio station player to discover and
> +listen to your favourite internet radio stations")

Could you turn the description into proper sentences, as per
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>?

Thanks in advance,
Ludo’.

Message #11 received at 73936 <at> debbugs.gnu.org (full text, mbox):

From: Ashish SHUKLA <ashish.is <at> lostca.se>
To: 73936 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: [PATCH v2] gnu: Add tuner.
Date: Tue, 31 Dec 2024 13:24:37 +0000

* gnu/packages/music.scm (tuner): New variable.

Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1
---
 gnu/packages/music.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 6825f14dcc..77922d9576 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2024 Parnikkapore <poomklao <at> yahoo.com>
 ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
 ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
+;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,6 +169,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages netpbm)
   #:use-module (gnu packages networking)
+  #:use-module (gnu packages pantheon)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
@@ -2868,6 +2870,58 @@ (define-public bristol
 is subjective.")
     (license license:gpl3+)))
 
+(define-public tuner
+  (package
+    (name "tuner")
+    (version "1.5.6")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/louis77/tuner")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256 (base32 "0zz91n56vdwhjwqscl21016i4l4lx3m6ja0fnrapmf16bdl0rrai"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list desktop-file-utils ; update-desktop-database
+           gettext-minimal
+           `(,glib "bin") ; glib-compile-schemas
+           ; for org.gnome.system.proxy schema
+           gsettings-desktop-schemas
+           `(,gtk "bin") ; gtk-update-icon-cache
+           pkg-config
+           vala))
+    (inputs
+      (list bash-minimal
+            glib
+            granite-6
+            gtk+
+            libgee
+            gstreamer
+            gst-plugins-base   ; for gstreamer 'playbin'
+            gst-plugins-good   ; for gstreamer 'scaletempo'
+            gst-plugins-bad
+            libsoup
+            json-glib-minimal))
+    (arguments
+      (list
+        #:glib-or-gtk? #t
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'install 'wrap-tuner
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out             (assoc-ref outputs "out"))
+                     (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                 (wrap-program (string-append out "/bin/com.github.louis77.tuner")
+                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
+    (home-page "https://github.com/louis77/tuner")
+    (synopsis "Application to discover and play internet radio stations")
+    (description "Tuner is a minimalist radio station player to discover and
+listen to your favourite internet radio stations.  The application consists of a radio
+station catalogue sourced from radio-browser.info, and has presets of selections of
+stations based on random, top, trending, genre.")
+    (license license:gpl3+)))
+
 (define-public tuxguitar
   (package
     (name "tuxguitar")

base-commit: c94153ca7715d8c073d89b6c0fcdb233c75d6440
-- 
2.47.1

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org>
Cc: ludo <at> gnu.org, Ashish SHUKLA <ashish.is <at> lostca.se>, 73936 <at> debbugs.gnu.org
Subject: Re: [bug#73936] [PATCH v2] gnu: Add tuner.
Date: Tue, 31 Dec 2024 21:40:49 +0800

[Message part 1 (text/plain, inline)]

Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/music.scm (tuner): New variable.
>
> Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1
> ---
>  gnu/packages/music.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 6825f14dcc..77922d9576 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -59,6 +59,7 @@
>  ;;; Copyright © 2024 Parnikkapore <poomklao <at> yahoo.com>
>  ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
>  ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
> +;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -168,6 +169,7 @@ (define-module (gnu packages music)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages netpbm)
>    #:use-module (gnu packages networking)
> +  #:use-module (gnu packages pantheon)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages pdf)
>    #:use-module (gnu packages perl)
> @@ -2868,6 +2870,58 @@ (define-public bristol
>  is subjective.")
>      (license license:gpl3+)))
>  
> +(define-public tuner
> +  (package
> +    (name "tuner")
> +    (version "1.5.6")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                     (url "https://github.com/louis77/tuner")
> +                     (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256 (base32 "0zz91n56vdwhjwqscl21016i4l4lx3m6ja0fnrapmf16bdl0rrai"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     (list desktop-file-utils ; update-desktop-database
> +           gettext-minimal
> +           `(,glib "bin") ; glib-compile-schemas
> +           ; for org.gnome.system.proxy schema
> +           gsettings-desktop-schemas
> +           `(,gtk "bin") ; gtk-update-icon-cache
> +           pkg-config
> +           vala))
> +    (inputs
> +      (list bash-minimal
> +            glib
> +            granite-6
> +            gtk+
> +            libgee
> +            gstreamer
> +            gst-plugins-base   ; for gstreamer 'playbin'
> +            gst-plugins-good   ; for gstreamer 'scaletempo'
> +            gst-plugins-bad
> +            libsoup
> +            json-glib-minimal))
> +    (arguments
> +      (list
> +        #:glib-or-gtk? #t
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'install 'wrap-tuner
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((out             (assoc-ref outputs "out"))
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                        please remove it.
> +                     (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> +                 (wrap-program (string-append out "/bin/com.github.louis77.tuner")
                                                 ^^^ for gexp, just use #$output

And this application's bin is com.github.louis77.tuner, maybe add a
soft link called tuner? Of course, this comment can be ignored.

> +                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
> +    (home-page "https://github.com/louis77/tuner")
> +    (synopsis "Application to discover and play internet radio stations")
> +    (description "Tuner is a minimalist radio station player to discover and
> +listen to your favourite internet radio stations.  The application consists of a radio
> +station catalogue sourced from radio-browser.info, and has presets of selections of
> +stations based on random, top, trending, genre.")
> +    (license license:gpl3+)))
> +
>  (define-public tuxguitar
>    (package
>      (name "tuxguitar")
>
> base-commit: c94153ca7715d8c073d89b6c0fcdb233c75d6440

[signature.asc (application/pgp-signature, inline)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Ashish SHUKLA" <ashish.is <at> lostca.se>
To: "Zheng Junjie" <zhengjunjie <at> iscas.ac.cn>, "Ashish SHUKLA via
 Guix-patches via" <guix-patches <at> gnu.org>
Cc: ludo <at> gnu.org, 73936 <at> debbugs.gnu.org
Subject: Re: [bug#73936] [PATCH v2] gnu: Add tuner.
Date: Tue, 31 Dec 2024 13:49:26 +0000

[Message part 1 (text/plain, inline)]

El 2024-12-31 21:40, Zheng Junjie escribió:
> Ashish SHUKLA via Guix-patches via <guix-patches <at> gnu.org> writes:
>
> > * gnu/packages/music.scm (tuner): New variable.
> >
> > Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1
> > ---
> >  gnu/packages/music.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >
> > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> > index 6825f14dcc..77922d9576 100644
> > --- a/gnu/packages/music.scm
> > +++ b/gnu/packages/music.scm
> > @@ -59,6 +59,7 @@
> >  ;;; Copyright © 2024 Parnikkapore <poomklao <at> yahoo.com>
> >  ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
> >  ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
> > +;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -168,6 +169,7 @@ (define-module (gnu packages music)
> >    #:use-module (gnu packages ncurses)
> >    #:use-module (gnu packages netpbm)
> >    #:use-module (gnu packages networking)
> > +  #:use-module (gnu packages pantheon)
> >    #:use-module (gnu packages pcre)
> >    #:use-module (gnu packages pdf)
> >    #:use-module (gnu packages perl)
> > @@ -2868,6 +2870,58 @@ (define-public bristol
> >  is subjective.")
> >      (license license:gpl3+)))
> >  
> > +(define-public tuner
> > +  (package
> > +    (name "tuner")
> > +    (version "1.5.6")
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                     (url "https://github.com/louis77/tuner")
> > +                     (commit (string-append "v" version))))
> > +              (file-name (git-file-name name version))
> > +              (sha256 (base32 "0zz91n56vdwhjwqscl21016i4l4lx3m6ja0fnrapmf16bdl0rrai"))))
> > +    (build-system meson-build-system)
> > +    (native-inputs
> > +     (list desktop-file-utils ; update-desktop-database
> > +           gettext-minimal
> > +           `(,glib "bin") ; glib-compile-schemas
> > +           ; for org.gnome.system.proxy schema
> > +           gsettings-desktop-schemas
> > +           `(,gtk "bin") ; gtk-update-icon-cache
> > +           pkg-config
> > +           vala))
> > +    (inputs
> > +      (list bash-minimal
> > +            glib
> > +            granite-6
> > +            gtk+
> > +            libgee
> > +            gstreamer
> > +            gst-plugins-base   ; for gstreamer 'playbin'
> > +            gst-plugins-good   ; for gstreamer 'scaletempo'
> > +            gst-plugins-bad
> > +            libsoup
> > +            json-glib-minimal))
> > +    (arguments
> > +      (list
> > +        #:glib-or-gtk? #t
> > +        #:phases
> > +        #~(modify-phases %standard-phases
> > +            (add-after 'install 'wrap-tuner
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (let ((out             (assoc-ref outputs "out"))
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                         please remove it.
> > +                     (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> > +                 (wrap-program (string-append out "/bin/com.github.louis77.tuner")
>                                                  ^^^ for gexp, just use #$output
>
> And this application's bin is com.github.louis77.tuner, maybe add a
> soft link called tuner? Of course, this comment can be ignored.

It's upstream's preference to have their executable named like this, so I'm not in the opinion of changing it.

Thanks!
-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 73936-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ashish SHUKLA <ashish.is <at> lostca.se>
Cc: 73936-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add tuner.
Date: Sat, 04 Jan 2025 22:02:24 +0100

Ashish SHUKLA <ashish.is <at> lostca.se> skribis:

> * gnu/packages/music.scm (tuner): New variable.
>
> Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.