GNU bug report logs - #73936
[PATCH] gnu: Add tuner.

Previous Next

Package: guix-patches;

Reported by: ashish.is <at> lostca.se

Date: Mon, 21 Oct 2024 17:56:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 73936 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ashish.is <at> lostca.se
Cc: 73936 <at> debbugs.gnu.org
Subject: Re: [bug#73936] [PATCH] gnu: Add tuner.
Date: Mon, 30 Dec 2024 00:00:51 +0100
Hi,

ashish.is <at> lostca.se skribis:

> From: Ashish SHUKLA <ashish.is <at> lostca.se>
>
> * gnu/packages/music.scm (tuner): New variable.
>
> Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1

It fell through the cracks…

> +    (native-inputs
> +     `(("desktop-file-utils" ,desktop-file-utils)       ; update-desktop-database
> +       ("gettext-minimal" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin")                         ; glib-compile-schemas
> +       ; for org.gnome.system.proxy schema
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gtk:bin" ,gtk "bin")                           ; gtk-update-icon-cache
> +       ("pkg-config" ,pkg-config)
> +       ("vala" ,vala)))

Could you remove input labels (‘guix style -S inputs’)?

> +    (home-page "https://github.com/louis77/tuner")
> +    (synopsis "Application to discover and play internet radio stations")
> +    (description "A minimalist radio station player to discover and
> +listen to your favourite internet radio stations")

Could you turn the description into proper sentences, as per
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>?

Thanks in advance,
Ludo’.




This bug report was last modified 191 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.