GNU bug report logs - #72796
30.0.50; [PATCH] php-ts-mode: Improved font locking

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72796: closed (30.0.50; [PATCH] php-ts-mode: Improved font
 locking)
Date: Mon, 26 Aug 2024 07:55:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 26 Aug 2024 00:52:41 -0700
with message-id <9FFE9897-83A8-4760-8BFA-F1EDC4195D02 <at> gmail.com>
and subject line Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
has caused the debbugs.gnu.org bug report #72796,
regarding 30.0.50; [PATCH] php-ts-mode: Improved font locking
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72796: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72796
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Sat, 24 Aug 2024 23:41:28 +0200

[Message part 3 (text/plain, inline)]

Hi, 
This patch improves font locking, particularly for constants and some 
operators. It also extends compatibility to the latest version of the PHP 
parser.
The patch can also be applied to version 31.0.50 .

Thanks
Vincenzo

[0001-Improve-php-ts-mode-font-lock-and-support-latest-par.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 72796-done <at> debbugs.gnu.org
Subject: Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Mon, 26 Aug 2024 00:52:41 -0700

[Message part 6 (text/plain, inline)]

> On Aug 24, 2024, at 2:41 PM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
> 
> Hi, 
> This patch improves font locking, particularly for constants and some 
> operators. It also extends compatibility to the latest version of the PHP 
> parser.
> The patch can also be applied to version 31.0.50 .
> 
> Thanks
> Vincenzo

[0001-Improve-php-ts-mode-font-lock-and-support-latest-par.patch (text/x-patch, attachment)]

[Message part 8 (text/plain, inline)]

Thanks Vince! I merged your patch to emacs-30. BTW, in the future it’s probably better to make the code work for both old and new grammar versions (whenever you can), that way people who installed the old grammar from who-knows-where can still use the mode. (I’m working on some tool to make it simpler to define alternative font-lock rules that works on multiple grammar versions.)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.