GNU bug report logs - #72796
30.0.50; [PATCH] php-ts-mode: Improved font locking

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72796 in the body.
You can then email your comments to 72796 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Sat, 24 Aug 2024 23:41:28 +0200

[Message part 1 (text/plain, inline)]

Hi, 
This patch improves font locking, particularly for constants and some 
operators. It also extends compatibility to the latest version of the PHP 
parser.
The patch can also be applied to version 31.0.50 .

Thanks
Vincenzo

[0001-Improve-php-ts-mode-font-lock-and-support-latest-par.patch (text/x-patch, attachment)]

Message #10 received at 72796-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 72796-done <at> debbugs.gnu.org
Subject: Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Mon, 26 Aug 2024 00:52:41 -0700

[Message part 1 (text/plain, inline)]

> On Aug 24, 2024, at 2:41 PM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
> 
> Hi, 
> This patch improves font locking, particularly for constants and some 
> operators. It also extends compatibility to the latest version of the PHP 
> parser.
> The patch can also be applied to version 31.0.50 .
> 
> Thanks
> Vincenzo

[0001-Improve-php-ts-mode-font-lock-and-support-latest-par.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks Vince! I merged your patch to emacs-30. BTW, in the future it’s probably better to make the code work for both old and new grammar versions (whenever you can), that way people who installed the old grammar from who-knows-where can still use the mode. (I’m working on some tool to make it simpler to define alternative font-lock rules that works on multiple grammar versions.)

Yuan

Message #13 received at 72796-done <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 72796-done <at> debbugs.gnu.org
Subject: Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Mon, 26 Aug 2024 12:16:23 +0200

[Message part 1 (text/plain, inline)]

Thanks Yuan.
I also tested the patch with the previous version of Grammar (v0.22.5) and
found no problems. Did you experience any problems?
Since php-ts-mode is not available in emacs-29 and emacs-30 has not been
released, perhaps it is better to support grammars from the release date.
Or is it better to support from the date of the first merge?  I have no
idea which is the best policy.
Thanks.
Vincenzo

Il giorno lun 26 ago 2024 alle ore 09:52 Yuan Fu <casouri <at> gmail.com> ha
scritto:

>
>
> > On Aug 24, 2024, at 2:41 PM, Vincenzo Pupillo <v.pupillo <at> gmail.com>
> wrote:
> >
> > Hi,
> > This patch improves font locking, particularly for constants and some
> > operators. It also extends compatibility to the latest version of the
> PHP
> > parser.
> > The patch can also be applied to version 31.0.50 .
> >
> > Thanks
> > Vincenzo
> Thanks Vince! I merged your patch to emacs-30. BTW, in the future it’s
> probably better to make the code work for both old and new grammar versions
> (whenever you can), that way people who installed the old grammar from
> who-knows-where can still use the mode. (I’m working on some tool to make
> it simpler to define alternative font-lock rules that works on multiple
> grammar versions.)
>
> Yuan

[Message part 2 (text/html, inline)]

Message #16 received at 72796 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: casouri <at> gmail.com, 72796 <at> debbugs.gnu.org
Subject: Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Mon, 26 Aug 2024 14:32:35 +0300

> Cc: 72796-done <at> debbugs.gnu.org
> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Date: Mon, 26 Aug 2024 12:16:23 +0200
> 
> Since php-ts-mode is not available in emacs-29 and emacs-30 has not been released, perhaps it is better to
> support grammars from the release date. Or is it better to support from the date of the first merge?  I have no
> idea which is the best policy.

We cannot be sure that users of this mode will necessarily have the
latest grammar library.  It depends on various factors, like the
installation policies on the user's system.  So I think it's best to
be tolerant to the version of the grammar, if this is feasible.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.