GNU bug report logs - #72797
qt-tools is unnecessary optional dependency for monero

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72797 in the body.
You can then email your comments to 72797 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 0xFFFC <0xFFFC0000 <at> proton.me>
To: "bug-guix <at> gnu.org" <bug-guix <at> gnu.org>
Subject: qt-tools is unnecessary optional dependency for monero
Date: Sat, 24 Aug 2024 20:26:03 +0000

[Message part 1 (text/plain, inline)]

Hi Guix community,

Thank you for your great software :)

I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).

Anyway to make this optional? or get rid of this?

1.https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/finance.scm#n716

Freedom wins.
0xFFFC

[Message part 2 (text/html, inline)]

Message #8 received at 72797 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: 0xFFFC <0xFFFC0000 <at> proton.me>
Cc: 72797 <at> debbugs.gnu.org
Subject: Re: bug#72797: qt-tools is unnecessary optional dependency for monero
Date: Sun, 25 Aug 2024 19:01:35 +0000

[Message part 1 (text/plain, inline)]

0xFFFC via Bug reports for GNU Guix <bug-guix <at> gnu.org> skribis:

> Hi Guix community,
>
> Thank you for your great software :)
>
> I noticed that the Monero package has an (a huge) unnecessary dependency here [1]. qt is an optional dependency for Monero code base (we only need that in case of using translations).
>
> Anyway to make this optional? or get rid of this?
>
> 1.https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/finance.scm#n716
>
> Freedom wins.
> 0xFFFC

Hi.

The qt-tools package is used to create the binary translations files
that are used by the monero-wallet-cli program, which seems to be
a useful thing.

What kind of issue is the dependency on qt-tools causing for you?

To disable translations, a variant of the monero package like the
following could work (not tested, I'm writing this example on the fly):

--8<---------------cut here---------------start------------->8---
(define-public monero-without-translations
  (inherit monero)
  (name monero-without-translations)
  (native-inputs (package-native-inputs monero)
    (delete "qttools-5")))
--8<---------------cut here---------------end--------------->8---

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 72797 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: 0xFFFC <0xFFFC0000 <at> proton.me>
Cc: 72797 <at> debbugs.gnu.org
Subject: Re: bug#72797: qt-tools is unnecessary optional dependency for monero
Date: Sun, 25 Aug 2024 21:25:42 +0000

[Message part 1 (text/plain, inline)]

Here's a corrected definition:

--8<---------------cut here---------------start------------->8---
(define-public monero-without-translations
  (package
    (inherit monero)
    (name "monero-without-translations")
    (native-inputs (modify-inputs (package-native-inputs monero)
                     (delete "qttools")))))
--8<---------------cut here---------------end--------------->8---

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 72797-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: GNU Debbugs <control <at> debbugs.gnu.org>, 0xFFFC <0xFFFC0000 <at> proton.me>,
 72797-done <at> debbugs.gnu.org
Subject: Re: bug#72797: qt-tools is unnecessary optional dependency for monero
Date: Sat, 14 Sep 2024 22:04:32 +0900

tag 72797 + notabug
quit

Hi Guillaume,

Guillaume Le Vaillant <glv <at> posteo.net> writes:

> Here's a corrected definition:
>
> (define-public monero-without-translations
>   (package
>     (inherit monero)
>     (name "monero-without-translations")
>     (native-inputs (modify-inputs (package-native-inputs monero)
>                      (delete "qttools")))))
>

Thanks for providing the above tip for users who'd like rewrite the
dependencies of monero.  Guix will continue shipping translations in its
stock package, so you should use the above.  qt-tools is also a native
dependency, so shouldn't end up in the closure of the built package.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.