GNU bug report logs - #72796
30.0.50; [PATCH] php-ts-mode: Improved font locking

Previous Next

Full log

Message #10 received at 72796-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 72796-done <at> debbugs.gnu.org
Subject: Re: bug#72796: 30.0.50; [PATCH] php-ts-mode: Improved font locking
Date: Mon, 26 Aug 2024 00:52:41 -0700

[Message part 1 (text/plain, inline)]

> On Aug 24, 2024, at 2:41 PM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
> 
> Hi, 
> This patch improves font locking, particularly for constants and some 
> operators. It also extends compatibility to the latest version of the PHP 
> parser.
> The patch can also be applied to version 31.0.50 .
> 
> Thanks
> Vincenzo

[0001-Improve-php-ts-mode-font-lock-and-support-latest-par.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks Vince! I merged your patch to emacs-30. BTW, in the future it’s probably better to make the code work for both old and new grammar versions (whenever you can), that way people who installed the old grammar from who-knows-where can still use the mode. (I’m working on some tool to make it simpler to define alternative font-lock rules that works on multiple grammar versions.)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.