GNU bug report logs - #71580
[PATCH] doc: Add message for common error about make check-system

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71580 in the body.
You can then email your comments to 71580 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] doc: Add message for common error about make check-system
Date: Sat, 15 Jun 2024 17:42:38 -0400

* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds were
run with different work trees. See https://issues.guix.gnu.org/47573.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
---
Sending a followup rebased on current master.

 doc/contributing.texi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..c9591dc9bf 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@ Running the Test Suite
 substitutes are available for their dependencies (@pxref{Substitutes}).
 Some of them require a lot of storage space to hold VM images.
 
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistency in the work tree from previous builds.  To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
 Again in case of test failures, please send @email{bug-guix@@gnu.org}
 all the details.
 

base-commit: 612e4dd98f7d1d015e405af9d029bede3fe3c280
-- 
2.45.1

Message #10 received at 71580 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 71580 <at> debbugs.gnu.org,
 Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#71580] [PATCH] doc: Add message for common error about
 make check-system
Date: Mon, 17 Jun 2024 17:07:48 -0400

Hi Richard,

Richard Sent <richard <at> freakingpenguin.com> writes:

> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
> may need to be run before running make check-system when previous builds were
> run with different work trees. See https://issues.guix.gnu.org/47573.
>
> Change-Id: I4b68d3a05f1425505816db969284487d725840d6
> ---
> Sending a followup rebased on current master.
>
>  doc/contributing.texi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index 938c8bfdb1..c9591dc9bf 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -411,6 +411,20 @@ Running the Test Suite
>  substitutes are available for their dependencies (@pxref{Substitutes}).
>  Some of them require a lot of storage space to hold VM images.
>  
> +If you encounter an error like:
> +
> +@example
> +Compiling Scheme modules...
> +ice-9/eval.scm:142:16: In procedure compile-top-call:
> +error: all-system-tests: unbound variable
> +hint: Did you forget `(use-modules (gnu tests))'?
> +@end example
> +
> +@noindent
> +there may be inconsistency in the work tree from previous builds.  To

perhaps        ^ an inconsistency?  alternatively, 'inconsistencies'.

> +resolve this, try running @command{make clean-go} followed by
> +@command{make}.
> +
>  Again in case of test failures, please send @email{bug-guix@@gnu.org}
>  all the details.

I guess the fact that there is an open issue from a different perhaps
about this problem on the tracker means it's bit enough people that it
merits to be mentioned in the doc.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #13 received at 71580 <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: 71580 <at> debbugs.gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH v2] doc: Add message for common error about make check-system
Date: Mon, 17 Jun 2024 21:02:29 -0400

* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds were
run with different work trees. See https://issues.guix.gnu.org/47573.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
---
Adjusted the phrasing. If we think it's best to hold on merging this
until we determine how common of an occurrence this is or (better yet)
resolve the issue entirely, there's no complaints by me. I'll leave
that decision up to you all. :)

 doc/contributing.texi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..6f0acc8c1f 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@ Running the Test Suite
 substitutes are available for their dependencies (@pxref{Substitutes}).
 Some of them require a lot of storage space to hold VM images.
 
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistencies in the work tree from previous builds.  To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
 Again in case of test failures, please send @email{bug-guix@@gnu.org}
 all the details.
 

base-commit: b993f4735d41e690dbafb8ee2e17fce996a8cf20
-- 
2.45.1

Message #16 received at 71580 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 71580 <at> debbugs.gnu.org,
 Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#71580] [PATCH v2] doc: Add message for common error about
 make check-system
Date: Tue, 18 Jun 2024 08:13:03 -0400

Richard Sent <richard <at> freakingpenguin.com> writes:

> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
> may need to be run before running make check-system when previous builds were
> run with different work trees. See https://issues.guix.gnu.org/47573.
>
> Change-Id: I4b68d3a05f1425505816db969284487d725840d6

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #19 received at 71580 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian" <pelzflorian <at> pelzflorian.de>
To: "Maxim Cournoyer" <maxim.cournoyer <at> gmail.com>
Cc: Richard Sent <richard <at> freakingpenguin.com>,
 Ludovic Courtès <ludo <at> gnu.org>, 71580 <at> debbugs.gnu.org,
 Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#71580] [PATCH v2] doc: Add message for common error about 
 make check-system
Date: Wed, 19 Jun 2024 10:48:18 +0200

[Message part 1 (text/plain, inline)]

I cannot push; my computer broke; but this patch should not be stuck because of me.  However, it is not clear why `make clean-go' helps.  I tried to switch branches, but cannot reproduce the issue and do not get this kind of error message.

Regards,
Florian
 

[Message part 2 (text/html, inline)]

Message #24 received at 71580-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 71580-done <at> debbugs.gnu.org,
 Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#71580] [PATCH v2] doc: Add message for common error about
 make check-system
Date: Mon, 24 Jun 2024 00:09:09 -0400

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Richard Sent <richard <at> freakingpenguin.com> writes:
>
>> * doc/contributing.texi (Running the Test Suite): Mention that make clean-go
>> may need to be run before running make check-system when previous builds were
>> run with different work trees. See https://issues.guix.gnu.org/47573.
>>
>> Change-Id: I4b68d3a05f1425505816db969284487d725840d6
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

Applied locally.  Will push shortly.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.