GNU bug report logs - #64452
[Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64452: closed ([Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*)
Date: Thu, 06 Jul 2023 08:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 06 Jul 2023 11:52:02 +0300
with message-id <83bkgpifrh.fsf <at> gnu.org>
and subject line Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*
has caused the debbugs.gnu.org bug report #64452,
regarding [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64452: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64452
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Wishlist/PATCH] Use special-mode for *Native-compile-log*,
 *Async-native-compile-log*
Date: Mon, 03 Jul 2023 20:13:23 -0400

[Message part 3 (text/plain, inline)]

Unless there is good reason not to use special-mode, it'd be nice 
to have the typical special-mode bindings (quit-window especially) 
in these buffers.

Rough draft patch attached. 

[0001-comp.el-use-special-mode-for-log-buffers.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 64452-done <at> debbugs.gnu.org, iarchivedmywholelife <at> gmail.com,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Thu, 06 Jul 2023 11:52:02 +0300

> From: Andrea Corallo <acorallo <at> gnu.org>
> Cc: No Wayman <iarchivedmywholelife <at> gmail.com>,  monnier <at> iro.umontreal.ca,
>   64452 <at> debbugs.gnu.org
> Date: Wed, 05 Jul 2023 10:47:47 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: No Wayman <iarchivedmywholelife <at> gmail.com>
> >> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier
> >>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org
> >> Date: Tue, 04 Jul 2023 18:21:00 -0400
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> > Thanks, but why not elisp-compile-mode, like we do in 
> >> > *Compile-log*
> >> > buffers for byte compilation?
> >> 
> >> Works for me. Revision attached.
> >> 
> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> >> index 22fb08e4688..5f42d10407f 100644
> >> --- a/lisp/emacs-lisp/comp.el
> >> +++ b/lisp/emacs-lisp/comp.el
> >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
> >>           (log-buffer
> >>               (or (get-buffer comp-log-buffer-name)
> >>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
> >> -                   (setf buffer-read-only t)
> >> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
> >> +                     (emacs-lisp-compilation-mode))
> >
> > bytecomp.el uses
> >
> >     (unless (derived-mode-p 'compilation-mode)
> >       (emacs-lisp-compilation-mode))
> >
> > Isn't that better?
> >
> > Also, do we really need to do this twice in comp-run-async-workers?
> >
> > Andrea, any comments?
> 
> No, haven't tried it but it LGTM form here.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.