GNU bug report logs - #64452
[Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64452 in the body.
You can then email your comments to 64452 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Wishlist/PATCH] Use special-mode for *Native-compile-log*,
 *Async-native-compile-log*
Date: Mon, 03 Jul 2023 20:13:23 -0400

[Message part 1 (text/plain, inline)]

Unless there is good reason not to use special-mode, it'd be nice 
to have the typical special-mode bindings (quit-window especially) 
in these buffers.

Rough draft patch attached. 

[0001-comp.el-use-special-mode-for-log-buffers.patch (text/x-patch, attachment)]

Message #8 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>,
 Andrea Corallo <acorallo <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 64452 <at> debbugs.gnu.org
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Tue, 04 Jul 2023 14:02:15 +0300

> From: No Wayman <iarchivedmywholelife <at> gmail.com>
> Date: Mon, 03 Jul 2023 20:13:23 -0400
> 
> Unless there is good reason not to use special-mode, it'd be nice 
> to have the typical special-mode bindings (quit-window especially) 
> in these buffers.
> 
> Rough draft patch attached. 

Thanks, but why not elisp-compile-mode, like we do in *Compile-log*
buffers for byte compilation?

Message #11 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64452 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Tue, 04 Jul 2023 18:21:00 -0400

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, but why not elisp-compile-mode, like we do in 
> *Compile-log*
> buffers for byte compilation?

Works for me. Revision attached.

[0001-comp.el-use-emacs-lisp-compilation-mode-for-log-buff.patch (text/x-patch, attachment)]

Message #14 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 64452 <at> debbugs.gnu.org, acorallo <at> gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Wed, 05 Jul 2023 14:25:48 +0300

> From: No Wayman <iarchivedmywholelife <at> gmail.com>
> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier
>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org
> Date: Tue, 04 Jul 2023 18:21:00 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but why not elisp-compile-mode, like we do in 
> > *Compile-log*
> > buffers for byte compilation?
> 
> Works for me. Revision attached.
> 
> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> index 22fb08e4688..5f42d10407f 100644
> --- a/lisp/emacs-lisp/comp.el
> +++ b/lisp/emacs-lisp/comp.el
> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
>           (log-buffer
>               (or (get-buffer comp-log-buffer-name)
>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
> -                   (setf buffer-read-only t)
> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
> +                     (emacs-lisp-compilation-mode))

bytecomp.el uses

    (unless (derived-mode-p 'compilation-mode)
      (emacs-lisp-compilation-mode))

Isn't that better?

Also, do we really need to do this twice in comp-run-async-workers?

Andrea, any comments?

Message #17 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: iarchivedmywholelife <iarchivedmywholelife <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64452 <at> debbugs.gnu.org, acorallo <at> gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Wed, 05 Jul 2023 08:52:44 -0400

[Message part 1 (text/plain, inline)]

Feel free to alter the patch as you see fit.I have no more time to invest in it.
-------- Original message --------From: Eli Zaretskii <eliz <at> gnu.org> Date: 7/5/23  7:25 AM  (GMT-05:00) To: No Wayman <iarchivedmywholelife <at> gmail.com> Cc: acorallo <at> gnu.org, monnier <at> iro.umontreal.ca, 64452 <at> debbugs.gnu.org Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* > From: No Wayman <iarchivedmywholelife <at> gmail.com>> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org> Date: Tue, 04 Jul 2023 18:21:00 -0400> > Eli Zaretskii <eliz <at> gnu.org> writes:> > > Thanks, but why not elisp-compile-mode, like we do in > > *Compile-log*> > buffers for byte compilation?> > Works for me. Revision attached.> > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el> index 22fb08e4688..5f42d10407f 100644> --- a/lisp/emacs-lisp/comp.el> +++ b/lisp/emacs-lisp/comp.el> @@ -1133,7 +1133,8 @@ comp-log-to-buffer>           (log-buffer>               (or (get-buffer comp-log-buffer-name)>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)> -                   (setf buffer-read-only t)> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)> +                     (emacs-lisp-compilation-mode))bytecomp.el uses    (unless (derived-mode-p 'compilation-mode)      (emacs-lisp-compilation-mode))Isn't that better?Also, do we really need to do this twice in comp-run-async-workers?Andrea, any comments?

[Message part 2 (text/html, inline)]

Message #20 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64452 <at> debbugs.gnu.org, No Wayman <iarchivedmywholelife <at> gmail.com>,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Wed, 05 Jul 2023 10:47:47 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: No Wayman <iarchivedmywholelife <at> gmail.com>
>> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier
>>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org
>> Date: Tue, 04 Jul 2023 18:21:00 -0400
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Thanks, but why not elisp-compile-mode, like we do in 
>> > *Compile-log*
>> > buffers for byte compilation?
>> 
>> Works for me. Revision attached.
>> 
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 22fb08e4688..5f42d10407f 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
>>           (log-buffer
>>               (or (get-buffer comp-log-buffer-name)
>>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
>> -                   (setf buffer-read-only t)
>> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
>> +                     (emacs-lisp-compilation-mode))
>
> bytecomp.el uses
>
>     (unless (derived-mode-p 'compilation-mode)
>       (emacs-lisp-compilation-mode))
>
> Isn't that better?
>
> Also, do we really need to do this twice in comp-run-async-workers?
>
> Andrea, any comments?

No, haven't tried it but it LGTM form here.

Bests

  Andrea

Message #25 received at 64452-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 64452-done <at> debbugs.gnu.org, iarchivedmywholelife <at> gmail.com,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Thu, 06 Jul 2023 11:52:02 +0300

> From: Andrea Corallo <acorallo <at> gnu.org>
> Cc: No Wayman <iarchivedmywholelife <at> gmail.com>,  monnier <at> iro.umontreal.ca,
>   64452 <at> debbugs.gnu.org
> Date: Wed, 05 Jul 2023 10:47:47 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: No Wayman <iarchivedmywholelife <at> gmail.com>
> >> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier
> >>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org
> >> Date: Tue, 04 Jul 2023 18:21:00 -0400
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> > Thanks, but why not elisp-compile-mode, like we do in 
> >> > *Compile-log*
> >> > buffers for byte compilation?
> >> 
> >> Works for me. Revision attached.
> >> 
> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> >> index 22fb08e4688..5f42d10407f 100644
> >> --- a/lisp/emacs-lisp/comp.el
> >> +++ b/lisp/emacs-lisp/comp.el
> >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
> >>           (log-buffer
> >>               (or (get-buffer comp-log-buffer-name)
> >>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
> >> -                   (setf buffer-read-only t)
> >> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
> >> +                     (emacs-lisp-compilation-mode))
> >
> > bytecomp.el uses
> >
> >     (unless (derived-mode-p 'compilation-mode)
> >       (emacs-lisp-compilation-mode))
> >
> > Isn't that better?
> >
> > Also, do we really need to do this twice in comp-run-async-workers?
> >
> > Andrea, any comments?
> 
> No, haven't tried it but it LGTM form here.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.