GNU bug report logs - #64451
30.0.50; split-root-window-right ignores side windows

Previous Next

To reply to this bug, email your comments to 64451 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; split-root-window-right ignores side windows
Date: Mon, 03 Jul 2023 19:38:01 -0400

(display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
M-x split-root-window-right

I would expect the new window to be to the left of the side window (I
know this is counter-intuitive to splititng the root window, but it's
also intuitive given the nature of side windows...)

I don't know if this is intentional. I also don't know if it's a
regression as it's not behavior I remember seeing until fairly recently.

In GNU Emacs 30.0.50 (build 51, aarch64-apple-darwin22.5.0, NS
 appkit-2299.60 Version 13.4.1 (Build 22F82)) of 2023-06-25 built on
 Aarons-Laptop.local
Repository revision: e85ebb3d82466c5838e9c6836e6d8b5c8d0a7c33
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.4.1

Configured using:
 'configure --with-ns --with-native-compilation --with-modules
 --without-dbus --without-webp --disable-ns-self-contained'

Configured features:
ACL GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS
PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER XIM
ZLIB

Message #8 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Aaron Jensen <aaronjensen <at> gmail.com>, martin rudalics <rudalics <at> gmx.at>
Cc: 64451 <at> debbugs.gnu.org
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Thu, 06 Jul 2023 10:52:50 +0300

> From: Aaron Jensen <aaronjensen <at> gmail.com>
> Date: Mon, 03 Jul 2023 19:38:01 -0400
> 
> 
> (display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
> M-x split-root-window-right
> 
> I would expect the new window to be to the left of the side window (I
> know this is counter-intuitive to splititng the root window, but it's
> also intuitive given the nature of side windows...)
> 
> I don't know if this is intentional. I also don't know if it's a
> regression as it's not behavior I remember seeing until fairly recently.

Martin, any comments?

Thanks.

Message #11 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Aaron Jensen <aaronjensen <at> gmail.com>
Cc: 64451 <at> debbugs.gnu.org
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Fri, 7 Jul 2023 15:57:12 +0200

[Message part 1 (text/plain, inline)]

>> (display-buffer "*scratch*" '(display-buffer-in-side-window . ((side . right))))
>> M-x split-root-window-right
>>
>> I would expect the new window to be to the left of the side window (I
>> know this is counter-intuitive to splititng the root window, but it's
>> also intuitive given the nature of side windows...)
>>
>> I don't know if this is intentional. I also don't know if it's a
>> regression as it's not behavior I remember seeing until fairly recently.
>
> Martin, any comments?

There are two bugs.  The first one is that splitting a root window with
side windows is always an error unless a new side window on another side
should be made.  This should be fixed by the attached patch.

The second bug is that the 'split-root-window-...' functions probably
should split 'window-main-window' on that frame instead.  I'd rather
leave the fix for that to the people who wrote those functions.

martin

[split-window.diff (text/x-patch, attachment)]

Message #14 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>, Hugo Heagren <hugo <at> heagren.com>
Cc: 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Sat, 08 Jul 2023 12:09:32 +0300

> Date: Fri, 7 Jul 2023 15:57:12 +0200
> Cc: 64451 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> 
> There are two bugs.  The first one is that splitting a root window with
> side windows is always an error unless a new side window on another side
> should be made.  This should be fixed by the attached patch.
> 
> The second bug is that the 'split-root-window-...' functions probably
> should split 'window-main-window' on that frame instead.  I'd rather
> leave the fix for that to the people who wrote those functions.

Hugo, I guess this means you?  Could you please look into this issue?

Thanks.

Message #17 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: hugo <at> heagren.com
Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Sat, 15 Jul 2023 10:51:34 +0300

Ping!  Hugo, could you please take a look?

> Cc: 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> Date: Sat, 08 Jul 2023 12:09:32 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Date: Fri, 7 Jul 2023 15:57:12 +0200
> > Cc: 64451 <at> debbugs.gnu.org
> > From: martin rudalics <rudalics <at> gmx.at>
> > 
> > There are two bugs.  The first one is that splitting a root window with
> > side windows is always an error unless a new side window on another side
> > should be made.  This should be fixed by the attached patch.
> > 
> > The second bug is that the 'split-root-window-...' functions probably
> > should split 'window-main-window' on that frame instead.  I'd rather
> > leave the fix for that to the people who wrote those functions.
> 
> Hugo, I guess this means you?  Could you please look into this issue?
> 
> Thanks.

Message #20 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: hugo <at> heagren.com
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Sun, 16 Jul 2023 17:54:12 +0100

On 2023-07-15 08:51, Eli Zaretskii wrote:
> Ping!  Hugo, could you please take a look?
> ...
>> Hugo, I guess this means you?  Could you please look into this issue?
>> 
>> Thanks.

Sorry, I've been on holiday and only just got back.

I'll take a look, and update once I have something useful to say.

Hugo

Message #23 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: hugo <at> heagren.com
Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Thu, 03 Aug 2023 10:40:28 +0300

Ping!  Any progress with this?

> Date: Sun, 16 Jul 2023 17:54:12 +0100
> From: hugo <at> heagren.com
> Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> 
> On 2023-07-15 08:51, Eli Zaretskii wrote:
> > Ping!  Hugo, could you please take a look?
> > ...
> >> Hugo, I guess this means you?  Could you please look into this issue?
> >> 
> >> Thanks.
> 
> Sorry, I've been on holiday and only just got back.
> 
> I'll take a look, and update once I have something useful to say.
> 
> Hugo
> 

Message #26 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: hugo <at> heagren.com
Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Sat, 12 Aug 2023 09:46:50 +0300

Ping! Ping!

> Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> Date: Thu, 03 Aug 2023 10:40:28 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping!  Any progress with this?
> 
> > Date: Sun, 16 Jul 2023 17:54:12 +0100
> > From: hugo <at> heagren.com
> > Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> > 
> > On 2023-07-15 08:51, Eli Zaretskii wrote:
> > > Ping!  Hugo, could you please take a look?
> > > ...
> > >> Hugo, I guess this means you?  Could you please look into this issue?
> > >> 
> > >> Thanks.
> > 
> > Sorry, I've been on holiday and only just got back.
> > 
> > I'll take a look, and update once I have something useful to say.
> > 
> > Hugo
> > 
> 
> 
> 
> 

Message #29 received at 64451 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: hugo <at> heagren.com
Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
Subject: Re: bug#64451: 30.0.50; split-root-window-right ignores side windows
Date: Sat, 19 Aug 2023 11:20:53 +0300

Ping! Ping! Ping!  Any progress with this?

> Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> Date: Sat, 12 Aug 2023 09:46:50 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping! Ping!
> 
> > Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> > Date: Thu, 03 Aug 2023 10:40:28 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > Ping!  Any progress with this?
> > 
> > > Date: Sun, 16 Jul 2023 17:54:12 +0100
> > > From: hugo <at> heagren.com
> > > Cc: rudalics <at> gmx.at, 64451 <at> debbugs.gnu.org, aaronjensen <at> gmail.com
> > > 
> > > On 2023-07-15 08:51, Eli Zaretskii wrote:
> > > > Ping!  Hugo, could you please take a look?
> > > > ...
> > > >> Hugo, I guess this means you?  Could you please look into this issue?
> > > >> 
> > > >> Thanks.
> > > 
> > > Sorry, I've been on holiday and only just got back.
> > > 
> > > I'll take a look, and update once I have something useful to say.
> > > 
> > > Hugo
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.