GNU bug report logs - #64452
[Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*

Previous Next

Full log

Message #20 received at 64452 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64452 <at> debbugs.gnu.org, No Wayman <iarchivedmywholelife <at> gmail.com>,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for
 *Native-compile-log*, *Async-native-compile-log*
Date: Wed, 05 Jul 2023 10:47:47 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: No Wayman <iarchivedmywholelife <at> gmail.com>
>> Cc: Andrea Corallo <acorallo <at> gnu.org>, Stefan Monnier
>>  <monnier <at> iro.umontreal.ca>, 64452 <at> debbugs.gnu.org
>> Date: Tue, 04 Jul 2023 18:21:00 -0400
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Thanks, but why not elisp-compile-mode, like we do in 
>> > *Compile-log*
>> > buffers for byte compilation?
>> 
>> Works for me. Revision attached.
>> 
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 22fb08e4688..5f42d10407f 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
>>           (log-buffer
>>               (or (get-buffer comp-log-buffer-name)
>>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
>> -                   (setf buffer-read-only t)
>> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
>> +                     (emacs-lisp-compilation-mode))
>
> bytecomp.el uses
>
>     (unless (derived-mode-p 'compilation-mode)
>       (emacs-lisp-compilation-mode))
>
> Isn't that better?
>
> Also, do we really need to do this twice in comp-run-async-workers?
>
> Andrea, any comments?

No, haven't tried it but it LGTM form here.

Bests

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.