GNU bug report logs - #6223
isearch-yank-string should use isearch-process-string

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Wed, 19 May 2010 23:40:03 UTC

Severity: minor

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6223 <at> debbugs.gnu.org
Subject: bug#6223: isearch-yank-string should use isearch-process-string
Date: Thu, 20 May 2010 03:16:01 +0300
> to be consistent IMO.

Thanks for the suggestion.  I see no problem with this change:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:14:58 +0000
@@ -1476,14 +1476,10 @@ (defun isearch-yank-string (string)
 	   (eq 'not-yanks search-upper-case))
       (setq string (downcase string)))
   (if isearch-regexp (setq string (regexp-quote string)))
-  (setq isearch-string (concat isearch-string string)
-	isearch-message
-	(concat isearch-message
-		(mapconcat 'isearch-text-char-description
-			   string ""))
-	;; Don't move cursor in reverse search.
-	isearch-yank-flag t)
-  (isearch-search-and-update))
+  ;; Don't move cursor in reverse search.
+  (setq isearch-yank-flag t)
+  (isearch-process-search-string
+   string (mapconcat 'isearch-text-char-description string "")))
 
 (defun isearch-yank-kill ()
   "Pull string from kill ring into search string."

-- 
Juri Linkov
http://www.jurta.org/emacs/




This bug report was last modified 15 years and 84 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.