GNU bug report logs - #6222
Shouldn't f1 in isearch-mode be help?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6222 in the body.
You can then email your comments to 6222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 01:30:27 +0200

C-h gives isearch help in isearch, but f1 does not. Should not both do
the same for consistency?

And should not `help-char' (or [help]) be used instead of C-h in the code?

The doc string for isearch does not mention that you now have this
good help for isearch during isearch. Shouldn't it do that?


BTW: My bad memory can't find a variable that is holding both C-h and
f1. Wasn't there such a variable?

Message #8 received at 6222 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6222 <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 03:20:04 +0300

> C-h gives isearch help in isearch, but f1 does not. Should not both do
> the same for consistency?
>
> And should not `help-char' (or [help]) be used instead of C-h in the code?
>
> The doc string for isearch does not mention that you now have this
> good help for isearch during isearch. Shouldn't it do that?
>
> BTW: My bad memory can't find a variable that is holding both C-h and
> f1. Wasn't there such a variable?

There is no such variable.  E.g. in help.el help bindings are repeated
three times:

    (define-key map (char-to-string help-char) 'help-for-help)
    (define-key map [help] 'help-for-help)
    (define-key map [f1] 'help-for-help)

and

    (define-key global-map (char-to-string help-char) 'help-command)
    (define-key global-map [help] 'help-command)
    (define-key global-map [f1] 'help-command)

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #11 received at 6222 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6222 <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 02:31:41 +0200

On Thu, May 20, 2010 at 2:20 AM, Juri Linkov <juri <at> jurta.org> wrote:
>> C-h gives isearch help in isearch, but f1 does not. Should not both do
>> the same for consistency?
>>
>> And should not `help-char' (or [help]) be used instead of C-h in the code?
>>
>> The doc string for isearch does not mention that you now have this
>> good help for isearch during isearch. Shouldn't it do that?
>>
>> BTW: My bad memory can't find a variable that is holding both C-h and
>> f1. Wasn't there such a variable?
>
> There is no such variable.  E.g. in help.el help bindings are repeated
> three times:
>
>    (define-key map (char-to-string help-char) 'help-for-help)
>    (define-key map [help] 'help-for-help)
>    (define-key map [f1] 'help-for-help)
>
> and
>
>    (define-key global-map (char-to-string help-char) 'help-command)
>    (define-key global-map [help] 'help-command)
>    (define-key global-map [f1] 'help-command)


Thanks, I see. But shouldn't isearch do the same then?

What about having a function in help.el for defining a binding for all
three possibilities? Something like

  (defun help-define-help-keys (map command)
    (define-key map (char-to-string help-char) command)
    (define-key map [help] command)
    (define-key map [f1] command))

Message #14 received at 6222 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6222 <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 03:38:57 +0300

>>    (define-key global-map (char-to-string help-char) 'help-command)
>>    (define-key global-map [help] 'help-command)
>>    (define-key global-map [f1] 'help-command)
>
> Thanks, I see. But shouldn't isearch do the same then?

I agree that it should:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:38:21 +0000
@@ -461,6 +461,9 @@ (defvar isearch-mode-map
     (define-key map    "\C-y" 'isearch-yank-line)
 
     (define-key map "\C-h" isearch-help-map)
+    (define-key map (char-to-string help-char) isearch-help-map)
+    (define-key map [help] isearch-help-map)
+    (define-key map [f1] isearch-help-map)
 
     (define-key map "\M-n" 'isearch-ring-advance)
     (define-key map "\M-p" 'isearch-ring-retreat)

> What about having a function in help.el for defining a binding for all
> three possibilities? Something like
>
>   (defun help-define-help-keys (map command)
>     (define-key map (char-to-string help-char) command)
>     (define-key map [help] command)
>     (define-key map [f1] command))

I'd rather remap all them to one key.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #17 received at 6222 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6222 <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Thu, 20 May 2010 02:47:32 +0200

On Thu, May 20, 2010 at 2:38 AM, Juri Linkov <juri <at> jurta.org> wrote:
>>>    (define-key global-map (char-to-string help-char) 'help-command)
>>>    (define-key global-map [help] 'help-command)
>>>    (define-key global-map [f1] 'help-command)
>>
>> Thanks, I see. But shouldn't isearch do the same then?
>
> I agree that it should:

Fine, thanks.

>> What about having a function in help.el for defining a binding for all
>> three possibilities? Something like
>>
>>   (defun help-define-help-keys (map command)
>>     (define-key map (char-to-string help-char) command)
>>     (define-key map [help] command)
>>     (define-key map [f1] command))
>
> I'd rather remap all them to one key.

I don't understand, but that is just because I do not know the details
of remap I guess. Otherwise it sounds reasonable.

Message #20 received at 6222 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6222 <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Wed, 19 May 2010 23:37:58 -0400

> BTW: My bad memory can't find a variable that is holding both C-h and
> f1. Wasn't there such a variable?

You're thinking of help-char and help-event-list.


        Stefan

Message #25 received at 6222-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6222-done <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Fri, 21 May 2010 01:04:52 +0300

Patch installed.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #26 received at 6222-done <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6222-done <at> debbugs.gnu.org
Subject: Re: bug#6222: Shouldn't f1 in isearch-mode be help?
Date: Fri, 21 May 2010 03:21:40 +0200

Thanks Juri.

On Fri, May 21, 2010 at 12:04 AM, Juri Linkov <juri <at> jurta.org> wrote:
> Patch installed.
>
> --
> Juri Linkov
> http://www.jurta.org/emacs/
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.