GNU bug report logs - #6223
isearch-yank-string should use isearch-process-string

Previous Next

Package: emacs;

Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>

Date: Wed, 19 May 2010 23:40:03 UTC

Severity: minor

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6223 in the body.
You can then email your comments to 6223 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6223; Package emacs. (Wed, 19 May 2010 23:40:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 19 May 2010 23:40:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: isearch-yank-string should use isearch-process-string
Date: Thu, 20 May 2010 01:38:54 +0200

to be consistent IMO.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6223; Package emacs. (Thu, 20 May 2010 00:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 6223 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6223 <at> debbugs.gnu.org
Subject: Re: bug#6223: isearch-yank-string should use isearch-process-string
Date: Thu, 20 May 2010 03:16:01 +0300

> to be consistent IMO.

Thanks for the suggestion.  I see no problem with this change:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:14:58 +0000
@@ -1476,14 +1476,10 @@ (defun isearch-yank-string (string)
 	   (eq 'not-yanks search-upper-case))
       (setq string (downcase string)))
   (if isearch-regexp (setq string (regexp-quote string)))
-  (setq isearch-string (concat isearch-string string)
-	isearch-message
-	(concat isearch-message
-		(mapconcat 'isearch-text-char-description
-			   string ""))
-	;; Don't move cursor in reverse search.
-	isearch-yank-flag t)
-  (isearch-search-and-update))
+  ;; Don't move cursor in reverse search.
+  (setq isearch-yank-flag t)
+  (isearch-process-search-string
+   string (mapconcat 'isearch-text-char-description string "")))
 
 (defun isearch-yank-kill ()
   "Pull string from kill ring into search string."

-- 
Juri Linkov
http://www.jurta.org/emacs/
Reply sent to Juri Linkov <juri <at> jurta.org>:
You have taken responsibility. (Thu, 20 May 2010 21:55:02 GMT) Full text and rfc822 format available.
Notification sent to Lennart Borgman <lennart.borgman <at> gmail.com>:
bug acknowledged by developer. (Thu, 20 May 2010 21:55:02 GMT) Full text and rfc822 format available.

Message #13 received at 6223-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6223-done <at> debbugs.gnu.org
Subject: Re: bug#6223: isearch-yank-string should use isearch-process-string
Date: Fri, 21 May 2010 00:52:08 +0300

Patch installed.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #14 received at 6223-done <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6223-done <at> debbugs.gnu.org
Subject: Re: bug#6223: isearch-yank-string should use isearch-process-string
Date: Fri, 21 May 2010 03:23:13 +0200

Thanks Juri.

On Thu, May 20, 2010 at 11:52 PM, Juri Linkov <juri <at> jurta.org> wrote:
> Patch installed.
>
> --
> Juri Linkov
> http://www.jurta.org/emacs/
>
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 18 Jun 2010 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.