GNU bug report logs - #60360
30.0.50; prog-fill-reindent-defun doesn't use region

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60360 in the body.
You can then email your comments to 60360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; prog-fill-reindent-defun doesn't use region
Date: Tue, 27 Dec 2022 20:13:02 +0200

X-Debbugs-CC: Theodor Thornhill <theo <at> thornhill.no>

After selecting the region in a docstring, M-q used to fill the region,
but new prog-fill-reindent-defun doesn't do this.  The original
function had the argument REGION for that, described thusly:

  The REGION argument is non-nil if called interactively; in that
  case, if Transient Mark mode is enabled and the mark is active,
  call ‘fill-region’ to fill each of the paragraphs in the active
  region, instead of just filling the current paragraph.

Message #8 received at 60360 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Juri Linkov <juri <at> linkov.net>, 60360 <at> debbugs.gnu.org
Subject: Re: bug#60360: 30.0.50; prog-fill-reindent-defun doesn't use region
Date: Tue, 27 Dec 2022 22:01:28 +0100

[Message part 1 (text/plain, inline)]

Hi, Juri!

> X-Debbugs-CC: Theodor Thornhill <theo <at> thornhill.no>
>
> After selecting the region in a docstring, M-q used to fill the region,
> but new prog-fill-reindent-defun doesn't do this.  The original
> function had the argument REGION for that, described thusly:
>
>   The REGION argument is non-nil if called interactively; in that
>   case, if Transient Mark mode is enabled and the mark is active,
>   call ‘fill-region’ to fill each of the paragraphs in the active
>   region, instead of just filling the current paragraph.

Thanks, does the below patch solve your problem?  If so, feel free to
install it, as I can't :-)

Theo

[0001-Fixes-in-prog-fill-reindent-defun.patch (text/x-diff, attachment)]

Message #11 received at 60360 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60360 <at> debbugs.gnu.org
Subject: Re: bug#60360: 30.0.50; prog-fill-reindent-defun doesn't use region
Date: Wed, 28 Dec 2022 19:22:26 +0200

close 60360 30.0.50
thanks

>> After selecting the region in a docstring, M-q used to fill the region,
>> but new prog-fill-reindent-defun doesn't do this.  The original
>> function had the argument REGION for that, described thusly:
>
> Thanks, does the below patch solve your problem?  If so, feel free to
> install it, as I can't :-)

Thanks for the patch.  I confirmed that it works,
and then pushed to master.

> @@ -164,10 +164,8 @@ prog-fill-reindent-defun
> ...
> +              (re-search-forward "^\\s<" (line-end-position) t))
> +          (fill-paragraph argument (region-active-p))

Usually use-region-p would be a better choice, but in this case
region-active-p is fine since it follows the logic used by
the REGION arg of fill-paragraph.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.