GNU bug report logs - #60322
30.0.50; [PATCH]: Search for comment at bol in prog-fill-reindent-defun

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60322 in the body.
You can then email your comments to 60322 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Sun, 25 Dec 2022 22:54:44 +0100

[Message part 1 (text/plain, inline)]

Hi!

Attached is a small adjustment to the regex used in
prog-fill-reindent-defun.  The point is that we shouldn't consider lines
where comments come after actual code as inside a comment.


Theo

[0001-Search-for-comment-at-bol-in-prog-fill-reindent-defu.patch (text/x-diff, attachment)]

Message #12 received at 60322 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>, Dmitry Gutov <dgutov <at> yandex.ru>,
 Yuan Fu <casouri <at> gmail.com>
Cc: 60322 <at> debbugs.gnu.org
Subject: Re: bug#60322: 30.0.50;
 [PATCH]: Search for comment at bol in prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 11:02:35 +0200

> Date: Sun, 25 Dec 2022 22:54:44 +0100
> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Attached is a small adjustment to the regex used in
> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
> where comments come after actual code as inside a comment.

Dmitry, Yuan, any comments?

Message #15 received at 60322 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Dmitry Gutov <dgutov <at> yandex.ru>, Yuan Fu
 <casouri <at> gmail.com>
Cc: 60322 <at> debbugs.gnu.org
Subject: Re: bug#60322: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 11:48:10 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 25 Dec 2022 22:54:44 +0100
>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Attached is a small adjustment to the regex used in
>> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
>> where comments come after actual code as inside a comment.
>
> Dmitry, Yuan, any comments?

This is adressed in f9a22cf78d1a7f6472b09c3046c6a7f6984bc2d2, so This
can be closed :-)

Theo

Message #18 received at 60322-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: casouri <at> gmail.com, 60322-done <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#60322: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 13:12:26 +0200

> From: Theodor Thornhill <theo <at> thornhill.no>
> Cc: 60322 <at> debbugs.gnu.org
> Date: Thu, 29 Dec 2022 11:48:10 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Date: Sun, 25 Dec 2022 22:54:44 +0100
> >> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> Attached is a small adjustment to the regex used in
> >> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
> >> where comments come after actual code as inside a comment.
> >
> > Dmitry, Yuan, any comments?
> 
> This is adressed in f9a22cf78d1a7f6472b09c3046c6a7f6984bc2d2, so This
> can be closed :-)

Thanks, done.

Message #21 received at 60322 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Theodor Thornhill <theo <at> thornhill.no>, 60322 <at> debbugs.gnu.org
Subject: Re: bug#60322: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 18:04:18 +0200

On 25/12/2022 23:54, Theodor Thornhill via Bug reports for GNU Emacs, 
the Swiss army knife of text editors wrote:
> Attached is a small adjustment to the regex used in
> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
> where comments come after actual code as inside a comment.

How about we allow indentation?

And allow to be called not from BOL too?

(re-search-forward "\\s-*\\s<" (line-end-position) t)

Message #24 received at 60322 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 60322 <at> debbugs.gnu.org
Subject: Re: bug#60322: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 20:23:08 +0100

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 25/12/2022 23:54, Theodor Thornhill via Bug reports for GNU Emacs, 
> the Swiss army knife of text editors wrote:
>> Attached is a small adjustment to the regex used in
>> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
>> where comments come after actual code as inside a comment.
>
> How about we allow indentation?
>
> And allow to be called not from BOL too?
>
> (re-search-forward "\\s-*\\s<" (line-end-position) t)

Sure!

Will you install it for me?

Theo

[0001-Allow-for-indentation-in-prog-fill-reindent-defun.patch (text/x-diff, attachment)]

Message #27 received at 60322 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Theodor Thornhill <theo <at> thornhill.no>, 60322 <at> debbugs.gnu.org
Subject: Re: bug#60322: 30.0.50; [PATCH]: Search for comment at bol in
 prog-fill-reindent-defun
Date: Thu, 29 Dec 2022 21:25:58 +0200

On 29/12/2022 21:23, Theodor Thornhill wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> On 25/12/2022 23:54, Theodor Thornhill via Bug reports for GNU Emacs,
>> the Swiss army knife of text editors wrote:
>>> Attached is a small adjustment to the regex used in
>>> prog-fill-reindent-defun.  The point is that we shouldn't consider lines
>>> where comments come after actual code as inside a comment.
>>
>> How about we allow indentation?
>>
>> And allow to be called not from BOL too?
>>
>> (re-search-forward "\\s-*\\s<" (line-end-position) t)
> 
> Sure!
> 
> Will you install it for me?

Sure, done.

I've also refilled the commit message a little.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.