GNU bug report logs - #59236
29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore

Previous Next

Package: emacs;

Reported by: lin Sun <sunlin7 <at> yahoo.com>

Date: Sun, 13 Nov 2022 04:28:02 UTC

Severity: normal

Tags: patch

Merged with 59139

Found in version 29.0.50

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59236: closed (29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory):
 Fix negated ignore)
Date: Sun, 13 Nov 2022 07:23:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 13 Nov 2022 07:22:36 +0000
with message-id <87edu7wc77.fsf <at> posteo.net>
and subject line Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
has caused the debbugs.gnu.org bug report #59236,
regarding 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59236: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59236
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Sun, 13 Nov 2022 04:26:45 +0000
[Message part 3 (text/plain, inline)]
Hi,

The patch 8638aace3f try to use the variable
`byte-compile-ignore-files`, but the logic is inverse for both file
and directory parts;
and the patch a01024c859 fix the logic for file part;
this patch try to fix the logic for directory part.

Please help review and apply it. Thanks.

Best regards
Lin
[0001-bytecomp.el-byte-recompile-directory-Fix-negated-ign.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59236-done <at> debbugs.gnu.org, lin Sun <sunlin7 <at> yahoo.com>
Subject: Re: bug#59236: 29.0.50; [PATCH] bytecomp.el:
 (byte-recompile-directory): Fix negated ignore
Date: Sun, 13 Nov 2022 07:22:36 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

> merge 59236 59139
> thanks
>
>> Date: Sun, 13 Nov 2022 04:26:45 +0000
>> From:  lin Sun via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> The patch 8638aace3f try to use the variable
>> `byte-compile-ignore-files`, but the logic is inverse for both file
>> and directory parts;
>> and the patch a01024c859 fix the logic for file part;
>> this patch try to fix the logic for directory part.
>> 
>> Please help review and apply it. Thanks.
>
> This is a duplicate of bug#59139.
>
> Philip, can you please take care of this?

I had applied the patch that was identical to the one proposed here, but
it appears my message confirming that wasn't sent out.  I'll update both
bug reports.


This bug report was last modified 2 years and 242 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.