GNU bug report logs - #59139
29.0.50; batch-byte-recompile-directory doesn't recompile file as expected

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59139 in the body.
You can then email your comments to 59139 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; batch-byte-recompile-directory doesn't recompile file as
 expected
Date: Wed, 9 Nov 2022 02:19:22 +0100

[Message part 1 (text/plain, inline)]

Hello,

I recently observed that batch-byte-recompile-directory no more
recompile .el files newer than their .elc file.

Here is the shell command I use:

emacs -batch --no-init-file --no-site-file --eval "(setq load-path [my
load path])" -f batch-byte-recompile-directory .

After some investigation, I found that commit
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8638aace3fbe01529f33870f469fa60bf5e43ee7
could be the culprit.

The attached patch fixed the above commit and solved the issue for me.

Thanks

In GNU Emacs 29.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-11-07 built on kilauea
Repository revision: d04433b96215d7d3387573f19cc315de86f2341a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (KDE Plasma)

Configured using:
 'configure --prefix=/home/dponce --with-x-toolkit=gtk3
 PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: fr_FR.utf8
  value of $LANG: fr_FR.UTF-8
  locale-coding-system: utf-8-unix

[bytecomp.el.patch (text/x-patch, attachment)]

Message #8 received at 59139 <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: 59139 <at> debbugs.gnu.org
Subject: bug#59139: Acknowledgement (29.0.50; batch-byte-recompile-directory
 doesn't recompile file as expected)
Date: Wed, 9 Nov 2022 10:41:39 +0100

Part of the issue (Bug#59115) has just been fixed by commit 
a01024c859fd98a4a330a9b627dc11232afc6ad0

However it seems my proposed patch is more complete.

Thanks!

Message #11 received at 59139 <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: 59139 <at> debbugs.gnu.org, 59115 <at> debbugs.gnu.org
Subject: 29.0.50; batch-byte-recompile-directory doesn't recompile file as
 expected
Date: Sat, 12 Nov 2022 17:01:52 +0100

Hello,

If I correctly understood the code, a fix similar to the one applied for Bug#59115
is also needed for directories.  Please find below another patch.
Please also feel free to close this Bug#59139.

diff --git a/bytecomp.el b/bytecomp.el
index c685e50..c81c42e 100644
--- a/bytecomp.el
+++ b/bytecomp.el
@@ -1941,11 +1941,10 @@ also be compiled."
 		      ;; This file is a subdirectory.  Handle them differently.
 		      (or (null arg) (eq 0 arg)
 			  (y-or-n-p (concat "Check " source "? ")))
-		      (setq directories (nconc directories (list source)))
                       ;; Directory is requested to be ignored
-                      (string-match-p
-                       (regexp-opt byte-compile-ignore-files)
-                       source)
+                      (not (string-match-p
+                            (regexp-opt byte-compile-ignore-files)
+                            source))
                       (setq directories (nconc directories (list source))))
                ;; It is an ordinary file.  Decide whether to compile it.
                (if (and (string-match emacs-lisp-file-regexp source)


Thanks!

Message #16 received at 59139 <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: 59139 <at> debbugs.gnu.org
Cc: Philip Kaludercic <philipk <at> posteo.net>, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59139: closed (Re: bug#59236: 29.0.50; [PATCH] bytecomp.el:
 (byte-recompile-directory): Fix negated ignore)
Date: Sun, 13 Nov 2022 11:12:30 +0100

On 13/11/2022 08:23, GNU bug Tracking System wrote:
> Your bug report
> 
> #59236: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected
> 
> which was filed against the emacs package, has been closed.
> 
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 59139 <at> debbugs.gnu.org.
> 

As mentioned in bug#59236 and my reported bug#59139, the patch
8638aace3f to use the variable `byte-compile-ignore-files` has
the logic inverse for both file and *directory* parts.
Currently the patch a01024c859 fixed the logic for file part, but
the fix to the directory part is still missing, as far as I can
see in master.  Currently, according to the code, when a
directory matchs `byte-compile-ignore-files` it is appended 2
times instead of being ignored.

Thanks

Message #19 received at 59139 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: David Ponce <da_vid <at> orange.fr>
Cc: 59139 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59139: closed (Re: bug#59236: 29.0.50; [PATCH] bytecomp.el:
 (byte-recompile-directory): Fix negated ignore)
Date: Mon, 14 Nov 2022 11:50:44 +0000

David Ponce <da_vid <at> orange.fr> writes:

> On 13/11/2022 08:23, GNU bug Tracking System wrote:
>> Your bug report
>> #59236: 29.0.50; batch-byte-recompile-directory doesn't recompile
>> file as expected
>> which was filed against the emacs package, has been closed.
>> The explanation is attached below, along with your original report.
>> If you require more details, please reply to 59139 <at> debbugs.gnu.org.
>> 
>
> As mentioned in bug#59236 and my reported bug#59139, the patch
> 8638aace3f to use the variable `byte-compile-ignore-files` has
> the logic inverse for both file and *directory* parts.
> Currently the patch a01024c859 fixed the logic for file part, but
> the fix to the directory part is still missing, as far as I can
> see in master.  Currently, according to the code, when a
> directory matchs `byte-compile-ignore-files` it is appended 2
> times instead of being ignored.

You are right.  I have also discovered that this is related to the
failing tests reported in bug#59109.  I'll rework your patch and apply
that then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.