GNU bug report logs - #59236
29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore

Previous Next

Package: emacs;

Reported by: lin Sun <sunlin7 <at> yahoo.com>

Date: Sun, 13 Nov 2022 04:28:02 UTC

Severity: normal

Tags: patch

Merged with 59139

Found in version 29.0.50

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59236 in the body.
You can then email your comments to 59236 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Sun, 13 Nov 2022 04:28:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to lin Sun <sunlin7 <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 13 Nov 2022 04:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Sun, 13 Nov 2022 04:26:45 +0000

[Message part 1 (text/plain, inline)]
Hi,

The patch 8638aace3f try to use the variable
`byte-compile-ignore-files`, but the logic is inverse for both file
and directory parts;
and the patch a01024c859 fix the logic for file part;
this patch try to fix the logic for directory part.

Please help review and apply it. Thanks.

Best regards
Lin

[0001-bytecomp.el-byte-recompile-directory-Fix-negated-ign.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Sun, 13 Nov 2022 07:13:02 GMT) Full text and rfc822 format available.

Message #8 received at 59236 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lin Sun <sunlin7 <at> yahoo.com>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 59236 <at> debbugs.gnu.org
Subject: Re: bug#59236: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Sun, 13 Nov 2022 09:12:47 +0200

merge 59236 59139
thanks

> Date: Sun, 13 Nov 2022 04:26:45 +0000
> From:  lin Sun via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The patch 8638aace3f try to use the variable
> `byte-compile-ignore-files`, but the logic is inverse for both file
> and directory parts;
> and the patch a01024c859 fix the logic for file part;
> this patch try to fix the logic for directory part.
> 
> Please help review and apply it. Thanks.

This is a duplicate of bug#59139.

Philip, can you please take care of this?
Merged 59139 59236. Request was from Eli Zaretskii <eliz <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 13 Nov 2022 07:13:02 GMT) Full text and rfc822 format available.
Reply sent to Philip Kaludercic <philipk <at> posteo.net>:
You have taken responsibility. (Sun, 13 Nov 2022 07:23:02 GMT) Full text and rfc822 format available.
Notification sent to lin Sun <sunlin7 <at> yahoo.com>:
bug acknowledged by developer. (Sun, 13 Nov 2022 07:23:02 GMT) Full text and rfc822 format available.

Message #15 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59236-done <at> debbugs.gnu.org, lin Sun <sunlin7 <at> yahoo.com>
Subject: Re: bug#59236: 29.0.50; [PATCH] bytecomp.el:
 (byte-recompile-directory): Fix negated ignore
Date: Sun, 13 Nov 2022 07:22:36 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

> merge 59236 59139
> thanks
>
>> Date: Sun, 13 Nov 2022 04:26:45 +0000
>> From:  lin Sun via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> The patch 8638aace3f try to use the variable
>> `byte-compile-ignore-files`, but the logic is inverse for both file
>> and directory parts;
>> and the patch a01024c859 fix the logic for file part;
>> this patch try to fix the logic for directory part.
>> 
>> Please help review and apply it. Thanks.
>
> This is a duplicate of bug#59139.
>
> Philip, can you please take care of this?

I had applied the patch that was identical to the one proposed here, but
it appears my message confirming that wasn't sent out.  I'll update both
bug reports.
Reply sent to Philip Kaludercic <philipk <at> posteo.net>:
You have taken responsibility. (Sun, 13 Nov 2022 07:23:02 GMT) Full text and rfc822 format available.
Notification sent to David Ponce <da_vid <at> orange.fr>:
bug acknowledged by developer. (Sun, 13 Nov 2022 07:23:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Sun, 13 Nov 2022 07:47:01 GMT) Full text and rfc822 format available.

Message #23 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59236-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59236: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Sat, 12 Nov 2022 23:45:49 -0800

[Message part 1 (text/plain, inline)]
Look forward for the fix. Thanks!

[Message part 2 (text/html, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Mon, 14 Nov 2022 17:54:02 GMT) Full text and rfc822 format available.

Message #26 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59236-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59236: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Mon, 14 Nov 2022 17:52:42 +0000

Hi,

Didn't see a path on the master  branch.
Can any one help apply the patch to fix byte-recompile-directory. Thanks
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Wed, 16 Nov 2022 19:22:02 GMT) Full text and rfc822 format available.

Message #29 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 59236-done <at> debbugs.gnu.org
Subject: Re: bug#59236: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Wed, 16 Nov 2022 19:21:11 +0000

Hi,

Just ping anyone available to apply the patch for this issue. Thanks

> Didn't see a path on the master  branch.
> Can any one help apply the patch to fix byte-recompile-directory. Thanks
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Wed, 16 Nov 2022 19:31:02 GMT) Full text and rfc822 format available.

Message #32 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: lin Sun <sunlin7 <at> yahoo.com>
Cc: 59236-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59236: 29.0.50; [PATCH] bytecomp.el:
 (byte-recompile-directory): Fix negated ignore
Date: Wed, 16 Nov 2022 19:30:06 +0000

lin Sun <sunlin7 <at> yahoo.com> writes:

> Hi,
>
> Just ping anyone available to apply the patch for this issue. Thanks
>
>> Didn't see a path on the master  branch.
>> Can any one help apply the patch to fix byte-recompile-directory. Thanks

I have applied the patch complete on a branch I am currently working on
that is related to this issue and bug#59109.  The branch should be
merged any day now.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59236; Package emacs. (Wed, 16 Nov 2022 19:44:01 GMT) Full text and rfc822 format available.

Message #35 received at 59236-done <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59236-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59236: 29.0.50;
 [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore
Date: Wed, 16 Nov 2022 19:43:11 +0000

Great, thanks for the update.
Look forward for the patch, I have local script failed on it : )
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 15 Dec 2022 12:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 238 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.