GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58940: closed ([PATCH] feature/tree-sitter: Add more font
 lock faces)
Date: Thu, 10 Nov 2022 11:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 10 Nov 2022 13:06:01 +0200
with message-id <831qqbrrvq.fsf <at> gnu.org>
and subject line Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
has caused the debbugs.gnu.org bug report #58940,
regarding [PATCH] feature/tree-sitter: Add more font lock faces
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58940: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58940
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Tue, 01 Nov 2022 01:21:03 +0000

[Message part 3 (text/plain, inline)]

The attached patch adds the following faces:

- font-lock-escape-face
- font-lock-number-face
- font-lock-operator-face
- font-lock-property-face
- font-lock-punctuation-face

font-lock-property-face inherits font-lock-variable-name-face which matches the behaviour of cc-mode and python-mode.

font-lock-escape-face inherits nothing. In python-mode, it inherits font-lock-constant-face, but not in cc-mode. Do we want it to inherit anything?

Hopefully I put everything in the right place.

[Message part 4 (text/html, inline)]

[0001-Add-more-font-lock-faces.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: dev <at> rjt.dev, 58940-done <at> debbugs.gnu.org
Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Thu, 10 Nov 2022 13:06:01 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 9 Nov 2022 19:59:30 -0800
> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>  58940 <at> debbugs.gnu.org
> 
> > Yuan, any further comments? If not, would you or someone else be able to push the patch?
> > 
> > Thanks.
> 
> I don’t have much to say, since this is not really about tree-sitter. I’ll wait for other folks to decide & push ;-)

I installed it, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.