GNU bug report logs - #58941
28.1.90; ERT tests and backtraces

Previous Next

Package: emacs;

Reported by: Ihor Radchenko <yantar92 <at> posteo.net>

Date: Tue, 1 Nov 2022 06:05:01 UTC

Severity: normal

Merged with 50629

Found in versions 28.0.50, 28.1.90

To reply to this bug, email your comments to 58941 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58941; Package emacs. (Tue, 01 Nov 2022 06:05:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ihor Radchenko <yantar92 <at> posteo.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 01 Nov 2022 06:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.1.90; ERT tests and backtraces
Date: Tue, 01 Nov 2022 06:04:49 +0000
Hi,

Currently, when one runs tests and error is thrown inside `should'
forms, no meaningful backtrace is being produced.

This is because `should' wraps the code into `condition-case' that
truncates the backtraces.

Would it be possible to allow more informative backtraces in failed ERT
tests?

An example of useless backtrace can be found in
https://builds.sr.ht/~bzg/job/872738:

Test test-ob-scheme/unspecified backtrace:
  signal(void-function (p))
  apply(signal (void-function (p)))
  (setq value-1494 (apply fn-1492 args-1493))
  (unwind-protect (setq value-1494 (apply fn-1492 args-1493)) (setq fo
  (if (unwind-protect (setq value-1494 (apply fn-1492 args-1493)) (set
  (let (form-description-1496) (if (unwind-protect (setq value-1494 (a
  (let ((value-1494 (quote ert-form-evaluation-aborted-1495))) (let (f
  (let* ((fn-1492 (function equal)) (args-1493 (condition-case err (le
  (closure (t) nil (let* ((fn-1492 (function equal)) (args-1493 (condi
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-ob-scheme/unspecified :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector "\\(org\\|ob\\|ox\\)" 
  ert-run-tests("\\(org\\|ob\\|ox\\)" #f(compiled-function (event-type
  ert-run-tests-batch("\\(org\\|ob\\|ox\\)")
  ert-run-tests-batch-and-exit("\\(org\\|ob\\|ox\\)")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("\\(org\\|ob\\|ox\\)")
  eval((org-test-run-batch-tests org-test-select-re))
  command-line-1(("--load" "/home/build/.emacs.d/init.el" "--eval" "(s
  command-line()
  normal-top-level()
Test test-ob-scheme/unspecified condition:
    (void-function p)
   FAILED   236/1034  test-ob-scheme/unspecified

The real backtrace there is

  p(nil)
  geiser-repl-project-root()
  geiser-repl-buffer-name(guile)
  geiser-repl--to-repl-buffer(guile)
  geiser-repl--start-repl(guile nil)
  geiser(guile)
  org-babel-scheme-get-repl(guile nil)
  org-babel-scheme-execute-with-geiser("'(1 2 3)" nil guile nil)
  org-babel-execute:scheme("'(1 2 3)" ((:colname-names) (:rowname-name
  org-babel-execute-src-block(nil)
  org-babel-execute-src-block-maybe()
  org-babel-execute-maybe()

      
-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58941; Package emacs. (Tue, 01 Nov 2022 07:25:01 GMT) Full text and rfc822 format available.

Message #8 received at 58941 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: 58941 <at> debbugs.gnu.org
Subject: Re: bug#58941: 28.1.90; ERT tests and backtraces
Date: Tue, 01 Nov 2022 08:24:23 +0100
Ihor Radchenko <yantar92 <at> posteo.net> writes:

> Hi,
>
> Currently, when one runs tests and error is thrown inside `should'
> forms, no meaningful backtrace is being produced.
>
> This is because `should' wraps the code into `condition-case' that
> truncates the backtraces.
>
> Would it be possible to allow more informative backtraces in failed ERT
> tests?
>
> An example of useless backtrace can be found in
> https://builds.sr.ht/~bzg/job/872738:

Yep, that's bug#50629@.  No solution in sight, I'm afraid.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58941; Package emacs. (Tue, 01 Nov 2022 08:32:02 GMT) Full text and rfc822 format available.

Message #11 received at 58941 <at> debbugs.gnu.org (full text, mbox):

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 58941 <at> debbugs.gnu.org
Subject: Re: bug#58941: 28.1.90; ERT tests and backtraces
Date: Tue, 01 Nov 2022 08:31:36 +0000
Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

>> An example of useless backtrace can be found in
>> https://builds.sr.ht/~bzg/job/872738:
>
> Yep, that's bug#50629@.  No solution in sight, I'm afraid.

Ouch. Sorry for the duplicate. (I even participated in the discussion
there :facepalm:)

Feel free to close.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58941; Package emacs. (Tue, 01 Nov 2022 08:39:02 GMT) Full text and rfc822 format available.

Message #14 received at 58941 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: 58941 <at> debbugs.gnu.org
Subject: Re: bug#58941: 28.1.90; ERT tests and backtraces
Date: Tue, 1 Nov 2022 09:38:52 +0100
On 01.11.22 09:31, Ihor Radchenko wrote:
> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
> 
> Feel free to close.

No problem, I'll let Lars decide.

Reading that you are an Org guy--maybe you could help with bug#58928?
That's presumably a problem with the new overlays detected in Org capture.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58941; Package emacs. (Tue, 01 Nov 2022 10:00:02 GMT) Full text and rfc822 format available.

Message #17 received at 58941 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>, 
 Ihor Radchenko <yantar92 <at> posteo.net>
Cc: 58941 <at> debbugs.gnu.org
Subject: Re: bug#58941: 28.1.90; ERT tests and backtraces
Date: Tue, 1 Nov 2022 02:59:31 -0700
forcemerge 50629 58941
thanks

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> Yep, that's bug#50629@.  No solution in sight, I'm afraid.




Forcibly Merged 50629 58941. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 01 Nov 2022 10:00:03 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 226 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.