GNU bug report logs - #58939
[PATCH] gnu: strawberry: Remove trailing #t from phases and snippet.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58939 in the body.
You can then email your comments to 58939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: strawberry: Remove trailing #t from phases and snippet.
Date: Tue,  1 Nov 2022 01:07:16 +0100

* gnu/packages/music.scm (strawberry)[arguments]<#:phases>: Remove trailing #t.
[snippet]: Likewise.
---
 gnu/packages/music.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index d493b09f07..c8dd415523 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -504,8 +504,7 @@ (define-public strawberry
                    (find-files "3rdparty"
                                (lambda (file stat)
                                  (string-match "^3rdparty/[^/]*$" file))
-                               #:directories? #t))
-                  #t))))
+                               #:directories? #t))))))
     (build-system cmake-build-system)
     (arguments
      `(#:test-target "run_strawberry_tests"
@@ -516,15 +515,13 @@ (define-public strawberry
              (let ((out             (assoc-ref outputs "out"))
                    (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
                (wrap-program (string-append out "/bin/strawberry")
-                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))
-               #t)))
+                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))))
          (add-before 'check 'pre-check
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((xorg-server (assoc-ref inputs "xorg-server")))
                (system (format #f "~a/bin/Xvfb :1 &" xorg-server))
                (setenv "DISPLAY" ":1")
-               (setenv "HOME" (getcwd))
-               #t))))))
+               (setenv "HOME" (getcwd))))))))
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("googletest" ,googletest)
-- 
2.38.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 58939-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58939] [PATCH] gnu: strawberry: Remove trailing #t from
 phases and snippet.
Date: Thu, 03 Nov 2022 18:52:18 +0100

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> * gnu/packages/music.scm (strawberry)[arguments]<#:phases>: Remove trailing #t.
> [snippet]: Likewise.
> ---
>  gnu/packages/music.scm | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Thanks! Pushed to master as 318581c5fc8f7716ad65d670eb7654a03a0e785d.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.