GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Package: emacs;

Reported by: Randy Taylor <dev <at> rjt.dev>

Date: Tue, 1 Nov 2022 01:22:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: dev <at> rjt.dev, casouri <at> gmail.com, stefankangas <at> gmail.com, 58940 <at> debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Mon, 07 Nov 2022 05:31:26 +0200
> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Randy Taylor <dev <at> rjt.dev>,
>   casouri <at> gmail.com,  58940 <at> debbugs.gnu.org
> Date: Sun, 06 Nov 2022 20:33:18 -0500
> 
> >> I suspect that's part of the reason.  Ideally, we'd phase out those old
> >> `font-lock-*-face` variables rather than introduce new ones.
> >> I think the only thing they bring nowadays is confusion.
> > Would it be worth it to make them obsolete?
> 
> I'd be in favor, yes.

I wouldn't.  There's gobs of code out there which will suddenly get
warnings.  For what purpose?  Those variables cause no harm
whatsoever.

We shouldn't be too eager to obsolete things that cause us no harm.




This bug report was last modified 2 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.