GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Full log

Message #50 received at 58940 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, 58940 <at> debbugs.gnu.org
Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Sun, 06 Nov 2022 17:02:13 +0000

[Message part 1 (text/plain, inline)]

On Sunday, November 6th, 2022 at 03:22, Eli Zaretskii <eliz <at> gnu.org> wrote:

> 
> > +(defface font-lock-property-face
> > + '((t :inherit font-lock-variable-name-face))
> > + "Font Lock mode face used to highlight properties of an object, such
> > +as the declaration and use of fields in a struct."
> 
> 
> The first line of a doc string should be a single complete sentence.
> 
> I suggest to have the detailed description be separate sentences
> after the first one.
> 

I wonder if that detailed description is really necessary anymore? Before the doc string read "...highlight properties". Now it reads "...highlight properties of an object." - perhaps that's enough? Regardless, I separated the detailed description out to its own sentence.

I also removed the variables.

[0001-Add-more-font-lock-faces-Bug-58940.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.