GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Full log

Message #41 received at 58940 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: casouri <at> gmail.com, 58940 <at> debbugs.gnu.org
Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Sun, 06 Nov 2022 10:22:45 +0200

> Date: Sun, 06 Nov 2022 01:00:38 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: casouri <at> gmail.com, 58940 <at> debbugs.gnu.org
> 
> On Saturday, November 5th, 2022 at 05:24, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> > I suggest an example of an escape sequence here, ideally from 2 or
> > more programming languages.
> 
> Example added, but not sure about a second programming language. Isn't it basically the same for most programming languages?

Maybe one example is enough, thanks.

> +(defface font-lock-property-face
> +  '((t :inherit font-lock-variable-name-face))
> +  "Font Lock mode face used to highlight properties of an object, such
> +as the declaration and use of fields in a struct."

The first line of a doc string should be a single complete sentence.

I suggest to have the detailed description be separate sentences
after the first one.

Otherwise, LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.