GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Full log

View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 58940 <at> debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Thu, 03 Nov 2022 02:30:13 +0000

On Wednesday, November 2nd, 2022 at 09:41, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> This face has customizations in the default and other themes, so it can
> be useful to do something with it.
> 
> It's also inherited from in highlight-escape-sequences (ELPA package).
> 
> As for modes which don't do anything with escape sequences, the upside
> is that they won't be affected: no chance to break anything.
> 

Sure, I think it makes sense to inherit it. Modes that don't currently do anything with escape sequences will be affected when using tree-sitter however, although it's just bold in this case, so not really a big deal. And they could just remove escape sequence highlighting in that case too, if they want.

I'll post an updated patch (with Eli's feedback) sometime tomorrow.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.