GNU bug report logs - #58940
[PATCH] feature/tree-sitter: Add more font lock faces

Previous Next

Full log

View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 58940 <at> debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Wed, 02 Nov 2022 02:04:12 +0000

[Message part 1 (text/plain, inline)]

On Monday, October 31st, 2022 at 22:14, Yuan Fu <casouri <at> gmail.com> wrote:

> Looks good! I would add a bit more explanation/example for font-lock-property-face and font-lock-punctuation-face. Eg, it’s not immediately clear to me what does preperty represent (property of an object as in obj.prop?). And it would be nice to say that punctuation-face are for commas and parenthesises.

I added explanations (and an example for property) to the
documentation.

I'm wondering if we want to separate out the punctuation as follows:
- font-lock-punctuation-delimiter-face
- font-lock-punctuation-bracket-face
- font-lock-punctuation-special-face for any punctuation that doesn't
  fit in the aforementioned categories.

These would all inherit from font-lock-punctuation-face.

I think it would be more useful than just having
font-lock-punctuation-face, since I think most people would style a
particular type of punctuation, as opposed to all of it. And in the
definition of the highlight queries, they will usually be grouped like
above anyway.

[0001-Add-more-font-lock-faces.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.