GNU bug report logs - #55946
29.0.50; minibuffer-mode lacks an abbrev table

Previous Next

Full log

Message #20 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 17:27:45 -0500

[Message part 1 (text/plain, inline)]

Hello,

On Mon 13 Jun 2022 at 05:26PM -04, Stefan Monnier wrote:

>>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>>> >> abbrev table.  There's a comment in minibuffer.el saying that this is
>>> >> because abbrev.el is not loaded early enough.
>>> >
>>> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
>>> > try changing that, and see if both a bootstrap and a simple build run
>>> > to completion OK.
>>>
>>> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
>>> I push to master so it can receive wider testing?
>>
>> Let's see what Stefan thinks about this.
>> Stefan, any comments?
>
> I couldn't find the corresponding patch, so I don't know what to say.

Just the attached simple change.

> The comment only refers to defining an abbrev table while loading
> `minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`.
> But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the
> problem seems to have disappeared.

Cool.

-- 
Sean Whitton

[0001-Add-abbrev-tables-for-minibuffer-mode-and-minibuffer.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.