GNU bug report logs - #55946
29.0.50; minibuffer-mode lacks an abbrev table

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55946 in the body.
You can then email your comments to 55946 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 11:38:43 -0500

Hello,

I'd like to define an abbrev for minibuffer-mode but it doesn't have an
abbrev table.  There's a comment in minibuffer.el saying that this is
because abbrev.el is not loaded early enough.  It would be useful to
have the abbrev table for this mode too.

-- 
Sean Whitton

Message #8 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 20:04:11 +0300

> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Date: Mon, 13 Jun 2022 11:38:43 -0500
> 
> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
> abbrev table.  There's a comment in minibuffer.el saying that this is
> because abbrev.el is not loaded early enough.

AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
try changing that, and see if both a bootstrap and a simple build run
to completion OK.

Message #11 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 12:35:43 -0500

Hello,

On Mon 13 Jun 2022 at 08:04PM +03, Eli Zaretskii wrote:

>> From: Sean Whitton <spwhitton <at> spwhitton.name>
>> Date: Mon, 13 Jun 2022 11:38:43 -0500
>>
>> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>> abbrev table.  There's a comment in minibuffer.el saying that this is
>> because abbrev.el is not loaded early enough.
>
> AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
> try changing that, and see if both a bootstrap and a simple build run
> to completion OK.

Thanks.  I see what you mean.  Tested both of those and it works.  Shall
I push to master so it can receive wider testing?

-- 
Sean Whitton

Message #14 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 20:50:37 +0300

> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Cc: 55946 <at> debbugs.gnu.org
> Date: Mon, 13 Jun 2022 12:35:43 -0500
> 
> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
> >> abbrev table.  There's a comment in minibuffer.el saying that this is
> >> because abbrev.el is not loaded early enough.
> >
> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
> > try changing that, and see if both a bootstrap and a simple build run
> > to completion OK.
> 
> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
> I push to master so it can receive wider testing?

Let's see what Stefan thinks about this.

Stefan, any comments?

Message #17 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55946 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 17:26:32 -0400

>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>> >> abbrev table.  There's a comment in minibuffer.el saying that this is
>> >> because abbrev.el is not loaded early enough.
>> >
>> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
>> > try changing that, and see if both a bootstrap and a simple build run
>> > to completion OK.
>> 
>> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
>> I push to master so it can receive wider testing?
>
> Let's see what Stefan thinks about this.
> Stefan, any comments?

I couldn't find the corresponding patch, so I don't know what to say.

The comment only refers to defining an abbrev table while loading
`minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`.
But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the
problem seems to have disappeared.


        Stefan

Message #20 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 17:27:45 -0500

[Message part 1 (text/plain, inline)]

Hello,

On Mon 13 Jun 2022 at 05:26PM -04, Stefan Monnier wrote:

>>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an
>>> >> abbrev table.  There's a comment in minibuffer.el saying that this is
>>> >> because abbrev.el is not loaded early enough.
>>> >
>>> > AFAICT, we only invoke this mode from C if it is fboundp.  So maybe
>>> > try changing that, and see if both a bootstrap and a simple build run
>>> > to completion OK.
>>>
>>> Thanks.  I see what you mean.  Tested both of those and it works.  Shall
>>> I push to master so it can receive wider testing?
>>
>> Let's see what Stefan thinks about this.
>> Stefan, any comments?
>
> I couldn't find the corresponding patch, so I don't know what to say.

Just the attached simple change.

> The comment only refers to defining an abbrev table while loading
> `minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`.
> But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the
> problem seems to have disappeared.

Cool.

-- 
Sean Whitton

[0001-Add-abbrev-tables-for-minibuffer-mode-and-minibuffer.patch (text/x-patch, attachment)]

Message #23 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 55946 <at> debbugs.gnu.org
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Mon, 13 Jun 2022 21:40:15 -0400

>> I couldn't find the corresponding patch, so I don't know what to say.
> Just the attached simple change.

Looks fine to me, thanks,


        Stefan

Message #28 received at 55946-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 55946-done <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Tue, 14 Jun 2022 14:38:43 -0500

Hello,

On Mon 13 Jun 2022 at 09:40PM -04, Stefan Monnier wrote:

>>> I couldn't find the corresponding patch, so I don't know what to say.
>> Just the attached simple change.
>
> Looks fine to me, thanks,

Thanks, pushed.  I don't believe this needs a NEWS entry, but happy to
write one if others thing otherwise.

-- 
Sean Whitton

Message #31 received at 55946 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: 55946 <at> debbugs.gnu.org
Cc: spwhitton <at> spwhitton.name
Subject: Re: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table
Date: Wed, 15 Jun 2022 10:54:00 +0200

>>>>> On Tue, 14 Jun 2022 14:38:43 -0500, Sean Whitton <spwhitton <at> spwhitton.name> said:

    Sean> Hello,
    Sean> On Mon 13 Jun 2022 at 09:40PM -04, Stefan Monnier wrote:

    >>>> I couldn't find the corresponding patch, so I don't know what to say.
    >>> Just the attached simple change.
    >> 
    >> Looks fine to me, thanks,

    Sean> Thanks, pushed.  I don't believe this needs a NEWS entry, but happy to
    Sean> write one if others thing otherwise.

Itʼs a new feature (in a sense) so announcing it would be nice.

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.