GNU bug report logs - #54572
[PATCH] gnu: solfege: Remove trailing booleans.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sat, 26 Mar 2022 01:16:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 54572 <at> debbugs.gnu.org
Subject: [bug#54572] [PATCH] gnu: solfege: Remove trailing booleans.
Date: Sat, 26 Mar 2022 10:14:43 +0100
Hi jgart

Am Freitag, dem 25.03.2022 um 21:15 -0400 schrieb jgart:
> * gnu/packages/music.scm (solfege): Remove trailing booleans.
> ---
>  gnu/packages/music.scm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6b530aac..d7f0c0d39d 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2058,16 +2058,14 @@ (define-public solfege
>                 (("/usr/bin/aplay") "aplay")
>                 (("/usr/bin/timidity") "timidity")
>                 (("/usr/bin/mpg123") "mpg123")
> -               (("/usr/bin/ogg123") "ogg123"))
> -             #t))
> +               (("/usr/bin/ogg123") "ogg123"))))
>           (add-before 'build 'patch-python-shebangs
>             (lambda _
>               ;; Two python scripts begin with a Unicode BOM, so
> patch-shebang
>               ;; has no effect.
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
> -               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))
> -             #t))
> +               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))))
Questionable uses of which.

It'd also be nice if you could update arguments to be a list of G-
expressions and do all the other modernizations.

Cheers




This bug report was last modified 3 years and 50 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.