GNU bug report logs - #54572
[PATCH] gnu: solfege: Remove trailing booleans.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54572 in the body.
You can then email your comments to 54572 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: solfege: Remove trailing booleans.
Date: Fri, 25 Mar 2022 21:15:38 -0400

* gnu/packages/music.scm (solfege): Remove trailing booleans.
---
 gnu/packages/music.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2c6b530aac..d7f0c0d39d 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2058,16 +2058,14 @@ (define-public solfege
                (("/usr/bin/aplay") "aplay")
                (("/usr/bin/timidity") "timidity")
                (("/usr/bin/mpg123") "mpg123")
-               (("/usr/bin/ogg123") "ogg123"))
-             #t))
+               (("/usr/bin/ogg123") "ogg123"))))
          (add-before 'build 'patch-python-shebangs
            (lambda _
              ;; Two python scripts begin with a Unicode BOM, so patch-shebang
              ;; has no effect.
              (substitute* '("solfege/parsetree.py"
                             "solfege/presetup.py")
-               (("#!/usr/bin/python") (string-append "#!" (which "python"))))
-             #t))
+               (("#!/usr/bin/python") (string-append "#!" (which "python"))))))
          (add-before 'build 'add-sitedirs
            ;; .pth files are not automatically interpreted unless the
            ;; directories containing them are added as "sites".  The directories
-- 
2.34.0

Message #8 received at 54572 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 54572 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: solfege: Remove trailing booleans.
Date: Sat, 26 Mar 2022 10:14:43 +0100

Hi jgart

Am Freitag, dem 25.03.2022 um 21:15 -0400 schrieb jgart:
> * gnu/packages/music.scm (solfege): Remove trailing booleans.
> ---
>  gnu/packages/music.scm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6b530aac..d7f0c0d39d 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2058,16 +2058,14 @@ (define-public solfege
>                 (("/usr/bin/aplay") "aplay")
>                 (("/usr/bin/timidity") "timidity")
>                 (("/usr/bin/mpg123") "mpg123")
> -               (("/usr/bin/ogg123") "ogg123"))
> -             #t))
> +               (("/usr/bin/ogg123") "ogg123"))))
>           (add-before 'build 'patch-python-shebangs
>             (lambda _
>               ;; Two python scripts begin with a Unicode BOM, so
> patch-shebang
>               ;; has no effect.
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
> -               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))
> -             #t))
> +               (("#!/usr/bin/python") (string-append "#!" (which
> "python"))))))
Questionable uses of which.

It'd also be nice if you could update arguments to be a list of G-
expressions and do all the other modernizations.

Cheers

Message #13 received at 54572-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 54572-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: bug#54572: [PATCH] gnu: solfege: Remove trailing booleans.
Date: Tue, 29 Mar 2022 10:57:29 +0200

Hey,

> Questionable uses of which.
>
> It'd also be nice if you could update arguments to be a list of G-
> expressions and do all the other modernizations.

That can come in a follow-up patch, pushed that one in the meantime.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.