GNU bug report logs - #54571
[PATCH] gnu: music21: Patch executables and add missing dependencies.

Previous Next

To reply to this bug, email your comments to 54571 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: music21: Patch executables and add missing dependencies.
Date: Fri, 25 Mar 2022 21:12:33 -0400

* gnu/packages/music.scm (music21)[arguments]: Patch executables.
[propagated-inputs]: Add python-matplotlib, python-jsonpickle, and
python-numpy.
[inputs]: Add lilypond, musescore, and xdg-utils.
---
 gnu/packages/music.scm | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 9c8203aa80..2c6b530aac 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1531,6 +1531,15 @@ (define-public music21
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-before 'build 'patch-executables
+           (lambda _
+             (substitute* '("music21/environment.py"
+                            "music21/lily/translate.py")
+               (("/usr/bin/lilypond") (which "lilypond"))
+               (("/usr/bin/mscore3") (which "mscore"))
+               (("/usr/bin/xdg-open") (which "xdg-open"))
+               (("LILYEXEC = 'lilypond'")
+                (string-append "LILYEXEC = '" (which "lilypond") "'")))))
          (replace 'check
            (lambda* (#:key tests? inputs outputs #:allow-other-keys)
              (when tests?
@@ -1538,8 +1547,17 @@ (define-public music21
                ;; See: https://github.com/cuthbertLab/music21/issues/1164
                (invoke "python" "-m" "music21.stream.tests")))))))
     (propagated-inputs
-      (list python-chardet python-joblib python-more-itertools
-            python-webcolors))
+      (list python-chardet
+            python-joblib
+            python-matplotlib
+            python-jsonpickle
+            python-more-itertools
+            python-webcolors
+            python-numpy))
+    (inputs
+      (list lilypond
+            musescore
+            xdg-utils))
     (home-page "https://web.mit.edu/music21/")
     (synopsis "Toolkit for Computational Musicology")
     (description
-- 
2.34.0

Message #8 received at 54571 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 54571 <at> debbugs.gnu.org
Subject: Re: [bug#54571] [PATCH] gnu: music21: Patch executables and add
 missing dependencies.
Date: Sat, 26 Mar 2022 10:33:22 +0100

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via schreef op vr 25-03-2022 om 21:12 [-0400]:
> +               (("/usr/bin/lilypond") (which "lilypond"))
> +               (("/usr/bin/mscore3") (which "mscore"))
> +               (("/usr/bin/xdg-open") (which "xdg-open"))
> +               (("LILYEXEC = 'lilypond'")
> +                (string-append "LILYEXEC = '" (which "lilypond") "'")))))
> [...]
> +    (inputs
> +      (list lilypond
> +            musescore
> +            xdg-utils))

'which' looks in native-inputs, not the 'inputs', so this is probably
incorrect when cross-compiling.  I suggest using (search-input-file
inputs "/bin/lilypond") instead.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54571 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 54571 <at> debbugs.gnu.org
Subject: Re: [bug#54571] [PATCH] gnu: music21: Patch executables and add
 missing dependencies.
Date: Sat, 26 Mar 2022 10:34:46 +0100

[Message part 1 (text/plain, inline)]

jgart via Guix-patches via schreef op vr 25-03-2022 om 21:12 [-0400]:
>      (propagated-inputs
> -      (list python-chardet python-joblib python-more-itertools
> -            python-webcolors))
> +      (list python-chardet
> +            python-joblib
> +            python-matplotlib
> +            python-jsonpickle
> +            python-more-itertools
> +            python-webcolors
> +            python-numpy))

It is a tool, and not (only?) a library, so do these need to be
propagated, or would some wrapping suffice?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.