GNU bug report logs - #54570
[PATCH] gnu: Add parole.

Previous Next

Package: guix-patches;

Reported by: tumashu <at> 163.com

Date: Fri, 25 Mar 2022 23:06:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54570 in the body.
You can then email your comments to 54570 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Fri, 25 Mar 2022 23:06:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to tumashu <at> 163.com:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 25 Mar 2022 23:06:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tumashu <at> 163.com
To: guix-patches <at> gnu.org
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH] gnu: Add parole.
Date: Sat, 26 Mar 2022 07:05:22 +0800

From: Feng Shu <tumashu <at> 163.com>

* gnu/packages/xfce.scm (parole): New variable.
---
 gnu/packages/xfce.scm | 44 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a2d8e99290..76f904d423 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -904,6 +904,50 @@ (define-public gigolo
 local and remote file systems and manage bookmarks of such.")
     (license gpl2)))                              ;version 2 only
 
+(define-public parole
+  (package
+    (name "parole")
+    (version "4.16.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/apps/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1rx7apylqb7mf1dl0sswj1630fca3ddk4x1gcdmlv5ykrkc5lc0d"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list (string-append "CPPFLAGS=-I"
+                             #$gst-plugins-base
+                             "/include/gstreamer-1.0"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'wrap-parole
+            (lambda _
+              (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                (wrap-program (string-append #$output "/bin/parole")
+                  `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
+    (native-inputs
+     (list pkg-config intltool gobject-introspection))
+    (inputs
+     (list dbus-glib
+           (list glib "bin")
+           gstreamer
+           gst-plugins-base
+           gst-plugins-good
+           libnotify
+           libxfce4ui
+           libxfce4util))
+    (home-page "https://www.xfce.org/")
+    (synopsis "Modern simple media player based on the GStreamer framework")
+    (description "Parole is a modern simple media player based on the
+GStreamer framework and written to fit well in the Xfce desktop.  Parole
+features playback of local media files, DVD/CD and live streams. ")
+    (license gpl2)))                    ;version 2 only
+
 (define-public xfce4-terminal
   (package
     (name "xfce4-terminal")
-- 
2.34.0
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Sat, 26 Mar 2022 12:32:02 GMT) Full text and rfc822 format available.

Message #8 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: tumashu <at> 163.com, 54570 <at> debbugs.gnu.org
Subject: Re: [bug#54570] [PATCH] gnu: Add parole.
Date: Sat, 26 Mar 2022 13:31:08 +0100

[Message part 1 (text/plain, inline)]
tumashu <at> 163.com schreef op za 26-03-2022 om 07:05 [+0800]:
> +                             #$gst-plugins-base

This hardcoding prevents package transformations.
Try #$(this-package-input "gst-plugins-base") instead.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Sat, 26 Mar 2022 12:45:01 GMT) Full text and rfc822 format available.

Message #11 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54570 <at> debbugs.gnu.org
Subject: Re: [bug#54570] [PATCH] gnu: Add parole.
Date: Sat, 26 Mar 2022 20:44:33 +0800

[Message part 1 (text/plain, inline)]
Maxime Devos <maximedevos <at> telenet.be> writes:

> tumashu <at> 163.com schreef op za 26-03-2022 om 07:05 [+0800]:
>> +                             #$gst-plugins-base
>
> This hardcoding prevents package transformations.
> Try #$(this-package-input "gst-plugins-base") instead.

Changed!



[0001-gnu-Add-parole.patch (text/x-patch, inline)]
From 03ca3c58c8bc54cec5e12cafbc6dc65aafcbd6cc Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Sat, 26 Mar 2022 07:01:25 +0800
Subject: [patch v2] gnu: Add parole.

* gnu/packages/xfce.scm (parole): New variable.
---
 gnu/packages/xfce.scm | 44 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index bc19fc5250..f7a0a94c7c 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -904,6 +904,50 @@ (define-public gigolo
 local and remote file systems and manage bookmarks of such.")
     (license gpl2)))                              ;version 2 only
 
+(define-public parole
+  (package
+    (name "parole")
+    (version "4.16.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://archive.xfce.org/src/apps/"
+                                  name "/" (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1rx7apylqb7mf1dl0sswj1630fca3ddk4x1gcdmlv5ykrkc5lc0d"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list (string-append "CPPFLAGS=-I"
+                             #$(this-package-input "gst-plugins-base")
+                             "/include/gstreamer-1.0"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'wrap-parole
+            (lambda _
+              (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                (wrap-program (string-append #$output "/bin/parole")
+                  `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
+    (native-inputs
+     (list pkg-config intltool gobject-introspection))
+    (inputs
+     (list dbus-glib
+           (list glib "bin")
+           gstreamer
+           gst-plugins-base
+           gst-plugins-good
+           libnotify
+           libxfce4ui
+           libxfce4util))
+    (home-page "https://www.xfce.org/")
+    (synopsis "Modern simple media player based on the GStreamer framework")
+    (description "Parole is a modern simple media player based on the
+GStreamer framework and written to fit well in the Xfce desktop.  Parole
+features playback of local media files, DVD/CD and live streams. ")
+    (license gpl2)))                    ;version 2 only
+
 (define-public xfce4-terminal
   (package
     (name "xfce4-terminal")
-- 
2.34.0


[Message part 3 (text/plain, inline)]


>
> Greetings,
> Maxime.
>

--
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Sat, 02 Apr 2022 23:42:01 GMT) Full text and rfc822 format available.

Message #14 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54570 <at> debbugs.gnu.org
Subject: Re: [bug#54570] [PATCH] gnu: Add parole.
Date: Sun, 03 Apr 2022 07:41:04 +0800

"Feng Shu" <tumashu <at> 163.com> writes:

> Maxime Devos <maximedevos <at> telenet.be> writes:
>
>> tumashu <at> 163.com schreef op za 26-03-2022 om 07:05 [+0800]:
>>> +                             #$gst-plugins-base
>>
>> This hardcoding prevents package transformations.
>> Try #$(this-package-input "gst-plugins-base") instead.
>
> Changed!
>

ping :-)

>
> From 03ca3c58c8bc54cec5e12cafbc6dc65aafcbd6cc Mon Sep 17 00:00:00 2001
> From: Feng Shu <tumashu <at> 163.com>
> Date: Sat, 26 Mar 2022 07:01:25 +0800
> Subject: [patch v2] gnu: Add parole.
>
> * gnu/packages/xfce.scm (parole): New variable.
> ---
>  gnu/packages/xfce.scm | 44 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index bc19fc5250..f7a0a94c7c 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -904,6 +904,50 @@ (define-public gigolo
>  local and remote file systems and manage bookmarks of such.")
>      (license gpl2)))                              ;version 2 only
>  
> +(define-public parole
> +  (package
> +    (name "parole")
> +    (version "4.16.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://archive.xfce.org/src/apps/"
> +                                  name "/" (version-major+minor version) "/"
> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "1rx7apylqb7mf1dl0sswj1630fca3ddk4x1gcdmlv5ykrkc5lc0d"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list
> +      #:configure-flags
> +      #~(list (string-append "CPPFLAGS=-I"
> +                             #$(this-package-input "gst-plugins-base")
> +                             "/include/gstreamer-1.0"))
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'install 'wrap-parole
> +            (lambda _
> +              (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> +                (wrap-program (string-append #$output "/bin/parole")
> +                  `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
> +    (native-inputs
> +     (list pkg-config intltool gobject-introspection))
> +    (inputs
> +     (list dbus-glib
> +           (list glib "bin")
> +           gstreamer
> +           gst-plugins-base
> +           gst-plugins-good
> +           libnotify
> +           libxfce4ui
> +           libxfce4util))
> +    (home-page "https://www.xfce.org/")
> +    (synopsis "Modern simple media player based on the GStreamer framework")
> +    (description "Parole is a modern simple media player based on the
> +GStreamer framework and written to fit well in the Xfce desktop.  Parole
> +features playback of local media files, DVD/CD and live streams. ")
> +    (license gpl2)))                    ;version 2 only
> +
>  (define-public xfce4-terminal
>    (package
>      (name "xfce4-terminal")
> -- 
> 2.34.0
>
>
>
>
>>
>> Greetings,
>> Maxime.
>>

--
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 04 Apr 2022 20:55:01 GMT) Full text and rfc822 format available.
Notification sent to tumashu <at> 163.com:
bug acknowledged by developer. (Mon, 04 Apr 2022 20:55:01 GMT) Full text and rfc822 format available.

Message #19 received at 54570-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Feng Shu" <tumashu <at> 163.com>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 54570-done <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Mon, 04 Apr 2022 22:54:11 +0200

[Message part 1 (text/plain, inline)]
Hi,

"Feng Shu" <tumashu <at> 163.com> skribis:

>>From 03ca3c58c8bc54cec5e12cafbc6dc65aafcbd6cc Mon Sep 17 00:00:00 2001
> From: Feng Shu <tumashu <at> 163.com>
> Date: Sat, 26 Mar 2022 07:01:25 +0800
> Subject: [patch v2] gnu: Add parole.
>
> * gnu/packages/xfce.scm (parole): New variable.

I made the minor changes below mostly to placate ‘guix lint’.

Thanks!

Ludo’.


[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a4bdc38aa3..44b6c34b29 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages xfce)
   #:use-module (gnu artwork)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages fonts)
@@ -926,14 +927,16 @@ (define-public parole
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'install 'wrap-parole
-            (lambda _
+            (lambda* (#:key inputs #:allow-other-keys)
               (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
                 (wrap-program (string-append #$output "/bin/parole")
+                  #:sh (search-input-file inputs "bin/bash")
                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
     (native-inputs
      (list pkg-config intltool gobject-introspection))
     (inputs
-     (list dbus-glib
+     (list bash-minimal                           ;for 'wrap-program'
+           dbus-glib
            (list glib "bin")
            gstreamer
            gst-plugins-base
@@ -942,10 +945,10 @@ (define-public parole
            libxfce4ui
            libxfce4util))
     (home-page "https://www.xfce.org/")
-    (synopsis "Modern simple media player based on the GStreamer framework")
+    (synopsis "Media player based on the GStreamer framework")
     (description "Parole is a modern simple media player based on the
 GStreamer framework and written to fit well in the Xfce desktop.  Parole
-features playback of local media files, DVD/CD and live streams. ")
+features playback of local media files, DVD/CD and live streams.")
     (license gpl2)))                    ;version 2 only
 
 (define-public xfce4-terminal
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Tue, 05 Apr 2022 09:26:01 GMT) Full text and rfc822 format available.

Message #22 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, Feng Shu
 <tumashu <at> 163.com>
Cc: 54570 <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Tue, 05 Apr 2022 11:25:29 +0200

[Message part 1 (text/plain, inline)]
Ludovic Courtès schreef op ma 04-04-2022 om 22:54 [+0200]:
> +                  #:sh (search-input-file inputs "bin/bash")

FWIW, this line is unneccessary due to the 'patch-shebangs' phase,
though it might be nice for explicitness.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Wed, 06 Apr 2022 08:11:01 GMT) Full text and rfc822 format available.

Message #25 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Feng Shu <tumashu <at> 163.com>, 54570 <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Wed, 06 Apr 2022 10:10:49 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op ma 04-04-2022 om 22:54 [+0200]:
>> +                  #:sh (search-input-file inputs "bin/bash")
>
> FWIW, this line is unneccessary due to the 'patch-shebangs' phase,

Is it?  The default value of #:sh is (which "bash"), which is the wrong
value when cross-compiling, isn’t it?

Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Wed, 06 Apr 2022 10:42:01 GMT) Full text and rfc822 format available.

Message #28 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Feng Shu <tumashu <at> 163.com>, 54570 <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Wed, 06 Apr 2022 12:41:21 +0200

[Message part 1 (text/plain, inline)]
Ludovic Courtès schreef op wo 06-04-2022 om 10:10 [+0200]:
> Maxime Devos <maximedevos <at> telenet.be> skribis:
> 
> > Ludovic Courtès schreef op ma 04-04-2022 om 22:54 [+0200]:
> > > +                  #:sh (search-input-file inputs "bin/bash")
> > 
> > FWIW, this line is unneccessary due to the 'patch-shebangs' phase,
> 
> Is it?  The default value of #:sh is (which "bash"), which is the wrong
> value when cross-compiling, isn’t it?

The default value is wrong when cross-compiling, so at least
temporarily, the shebang will be wrong.  However, %standard-phases has

(phases ... install patch-shebangs ...)

so after the 'wrap-parole' phase, 'patch-shebangs' is run, and this
phase will correct the shebang.

<https://lists.gnu.org/r/guix-devel/2021-06/msg00027.html> goes into
more detail.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#54570; Package guix-patches. (Wed, 06 Apr 2022 12:24:01 GMT) Full text and rfc822 format available.

Message #31 received at 54570 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Feng Shu <tumashu <at> 163.com>, 54570 <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Wed, 06 Apr 2022 14:23:02 +0200

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op wo 06-04-2022 om 10:10 [+0200]:
>> Maxime Devos <maximedevos <at> telenet.be> skribis:
>> 
>> > Ludovic Courtès schreef op ma 04-04-2022 om 22:54 [+0200]:
>> > > +                  #:sh (search-input-file inputs "bin/bash")
>> > 
>> > FWIW, this line is unneccessary due to the 'patch-shebangs' phase,
>> 
>> Is it?  The default value of #:sh is (which "bash"), which is the wrong
>> value when cross-compiling, isn’t it?
>
> The default value is wrong when cross-compiling, so at least
> temporarily, the shebang will be wrong.  However, %standard-phases has
>
> (phases ... install patch-shebangs ...)
>
> so after the 'wrap-parole' phase, 'patch-shebangs' is run, and this
> phase will correct the shebang.

Oh, got it; this is perfect.

Thanks,
Ludo’.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 May 2022 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 40 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.