GNU bug report logs - #54570
[PATCH] gnu: Add parole.

Previous Next

Full log

Message #19 received at 54570-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Feng Shu" <tumashu <at> 163.com>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 54570-done <at> debbugs.gnu.org
Subject: Re: bug#54570: [PATCH] gnu: Add parole.
Date: Mon, 04 Apr 2022 22:54:11 +0200

[Message part 1 (text/plain, inline)]

Hi,

"Feng Shu" <tumashu <at> 163.com> skribis:

>>From 03ca3c58c8bc54cec5e12cafbc6dc65aafcbd6cc Mon Sep 17 00:00:00 2001
> From: Feng Shu <tumashu <at> 163.com>
> Date: Sat, 26 Mar 2022 07:01:25 +0800
> Subject: [patch v2] gnu: Add parole.
>
> * gnu/packages/xfce.scm (parole): New variable.

I made the minor changes below mostly to placate ‘guix lint’.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index a4bdc38aa3..44b6c34b29 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages xfce)
   #:use-module (gnu artwork)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages fonts)
@@ -926,14 +927,16 @@ (define-public parole
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'install 'wrap-parole
-            (lambda _
+            (lambda* (#:key inputs #:allow-other-keys)
               (let ((gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
                 (wrap-program (string-append #$output "/bin/parole")
+                  #:sh (search-input-file inputs "bin/bash")
                   `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))))))
     (native-inputs
      (list pkg-config intltool gobject-introspection))
     (inputs
-     (list dbus-glib
+     (list bash-minimal                           ;for 'wrap-program'
+           dbus-glib
            (list glib "bin")
            gstreamer
            gst-plugins-base
@@ -942,10 +945,10 @@ (define-public parole
            libxfce4ui
            libxfce4util))
     (home-page "https://www.xfce.org/")
-    (synopsis "Modern simple media player based on the GStreamer framework")
+    (synopsis "Media player based on the GStreamer framework")
     (description "Parole is a modern simple media player based on the
 GStreamer framework and written to fit well in the Xfce desktop.  Parole
-features playback of local media files, DVD/CD and live streams. ")
+features playback of local media files, DVD/CD and live streams.")
     (license gpl2)))                    ;version 2 only
 
 (define-public xfce4-terminal

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.