GNU bug report logs - #54232
[PATCH] gnu: python-daemon: Fix build by temporarily disabling the tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Attila Lendvai <attila <at> lendvai.name>
Subject: bug#54232: closed (Re: [bug#54232] [PATCH 1/2] gnu:
 python-daemon: Use the git repo as source instead of pypi.)
Date: Thu, 03 Mar 2022 14:47:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#54232: [PATCH] gnu: python-daemon: Fix build by temporarily disabling the tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 54232 <at> debbugs.gnu.org.

-- 
54232: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54232
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 54232-done <at> debbugs.gnu.org
Subject: Re: [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as
 source instead of pypi.
Date: Thu, 03 Mar 2022 15:46:15 +0100

[Message part 3 (text/plain, inline)]

Attila Lendvai schreef op do 03-03-2022 om 14:42 [+0000]:
> > Also, how does this address the test failure? The pypi and git are
> > at
> > the same version. Did upstream adjust the 'release/2.3.0' tag in
> > place
> > or something?
> 
> sorry for not being clear enough! sending this patch was essentially
> a mistake: the tests do work fine.
> 
> probably i have added the disabling of the test prior to the
> SUBSTITUTE* (that
> is basically a backport of the fix commit in upstream), and when i
> rebased some
> pending changes, then i mistakenly included the now irrelevant
> disabling.
> 
> feel free to apply or reject this as you see fit. it's not important
> for me to build from git, even though i also find it better. probably
> the software heritage archives also work better with git.

They do support tarballs to some degree, and disarchive to some degree
compensates for mismatches.  I don't know how well this works in
practice.

Anyway, I'm closing for now, but if it is discussed on guix-devel@ with
a positive conclusion, feel free to reopen.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Attila Lendvai <attila <at> lendvai.name>
To: guix-patches <at> gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] gnu: python-daemon: Fix build by temporarily disabling the
 tests.
Date: Thu,  3 Mar 2022 11:58:52 +0100

A test is failing due to a new version of a dependency (`safe_hasattr` was
deleted from `testtools.helpers`).  Disable tests until the next release.

Also point the origin to the github repo instead of pypy.
---
 gnu/packages/python-xyz.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c05502388e..3c9463b2c8 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -4163,14 +4163,17 @@ (define-public python-daemon
     (version "2.3.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (pypi-uri "python-daemon" version))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://pagure.io/python-daemon.git")
+             (commit (string-append "release/" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32
-         "1bxfn2bq56sd4w0nm9mqy8y0905m7fc8vmhnjxlrf49vcbqr7adx"))))
+        (base32 "1ysynb1m9vsww2nmhcypkk08xwifc3gw5yq10h1a1i11yn27w4y6"))))
     (build-system python-build-system)
     (arguments
-     `(#:phases
+     `(#:tests? #false ; TODO reenable; tests got fixed after v2.3.0
+       #:phases
        (modify-phases %standard-phases
          (add-before 'check 'adjust-tests
            (lambda _
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.