GNU bug report logs - #54231
[PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54231 in the body.
You can then email your comments to 54231 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: guix-patches <at> gnu.org
Cc: Attila Lendvai <attila <at> lendvai.name>
Subject: [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.
Date: Thu,  3 Mar 2022 11:58:02 +0100

It used to work before the new sanity_check.py was added, and the build result
still seems to work fine.
---
 gnu/packages/finance.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 985eaa87f7..26c546caed 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1156,6 +1156,7 @@ (define-public trezor-agent
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (delete 'sanity-check) ; TODO It fails, but the package works fine.
          (add-after 'wrap 'fixup-agent-py
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out")))
-- 
2.34.0

Message #8 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 54231 <at> debbugs.gnu.org
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Thu, 03 Mar 2022 13:28:18 +0100

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op do 03-03-2022 om 11:58 [+0100]:
> +         (delete 'sanity-check) ; TODO It fails, but the package works fine.

How does it fail?  Maybe it indicates a real problem that merely
happens to be difficult to trigger in practice.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54231 <at> debbugs.gnu.org
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Thu, 03 Mar 2022 14:24:53 +0000

[Message part 1 (text/plain, inline)]

> > +         (delete 'sanity-check) ; TODO It fails, but the package works fine.
>
> How does it fail? Maybe it indicates a real problem that merely
> happens to be difficult to trigger in practice.


unfortunately i'm not a python expert, i don't know why it fails, but currently it doesn't even build.

i have attached the relevant part of the build output.

if you scan python-xyz.scm, this phase is deleted in several other packages.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“There is nothing sacrosanct about the majority; the lynch mob, too, is the majority in its own domain.”
	— Murray N. Rothbard (1926–1995), 'For a New Liberty' (1973)

[trezor-agent.log (text/x-log, attachment)]

Message #14 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Marek Paśnikowski <mail <at> marekpasnikowski.name>
To: 54231 <at> debbugs.gnu.org
Subject: [PATCH] gnu: trezor-agent: Fix it by deleting the sanity-check phase.
Date: Wed, 30 Mar 2022 15:29:53 +0200

Greetings

I am a Guix newbie, so I do not know yet, how to find the package
source.

Does this package declare `python-trezor-agent` as a dependency? The
error message hints at this missing dependency.

Message #17 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Attila Lendvai <attila <at> lendvai.name>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54231 <at> debbugs.gnu.org
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Tue, 12 Apr 2022 10:41:38 +0000

would it be possible to get this in? or another fix that restores the
package's buildability?

the tests can be fixed later by a python expert that wanders around
here.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“It is the mark of an educated mind to be able to entertain a thought without accepting it.”
	— Aristotle (BC 384–322), 'Metaphysics'

Message #20 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 54231 <at> debbugs.gnu.org
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Tue, 12 Apr 2022 13:11:17 +0200

[Message part 1 (text/plain, inline)]

Attila Lendvai schreef op di 12-04-2022 om 10:41 [+0000]:
> would it be possible to get this in? or another fix that restores the
> package's buildability?
> 
> the tests can be fixed later by a python expert that wanders around
> here.

It looks like 'trezor-agent' only has a python script and not a python
module, so no wonder that 'sanity-check' fails to find the module.  As
such, I believe that the 'sanity-check' phase can indeed be removed in
this case, if accompanied an appropriate comment.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 54231-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 54231-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Tue, 12 Apr 2022 12:04:10 +0000

[Message part 1 (text/plain, inline)]

Patch pushed as d3d2881acf4f3efef61a4049ea4c7c3ba883f48c with a comment
explaining why the 'sanity-check' phase is deleted.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 54231 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Marek Paśnikowski <mail <at> marekpasnikowski.name>, 
 54231 <at> debbugs.gnu.org
Subject: Re: [bug#54231] [PATCH] gnu: trezor-agent: Fix it by deleting the
 sanity-check phase.
Date: Tue, 12 Apr 2022 14:29:23 +0200

[Message part 1 (text/plain, inline)]

Marek Paśnikowski schreef op wo 30-03-2022 om 15:29 [+0200]:
> Does this package declare `python-trezor-agent` as a dependency? The
> error message hints at this missing dependency.

Yes, it does:

    (inputs
     (list python-trezor python-trezor-agent))

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.