GNU bug report logs - #54233
29.0.50; [PATCH] Missing symbols in tex--prettify-symbols-alist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54233 in the body.
You can then email your comments to 54233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: emacs-bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; [PATCH] Missing symbols in tex--prettify-symbols-alist
Date: Thu, 03 Mar 2022 12:48:02 +0100

[Message part 1 (text/plain, inline)]

Hi all,

I'd like to propose the following change to
`tex--prettify-symbols-alist'.  It adds support for macros formerly
provided by textcomp package which are now part of LaTeX kernel.  I will
prepare a format-patch once this change is accepted.

Any comments welcome.

Best, Arash

[tex-prettify.diff (text/x-patch, attachment)]

Message #8 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Thu, 03 Mar 2022 14:55:11 +0100

Arash Esbati <arash <at> gnu.org> writes:

> I'd like to propose the following change to
> `tex--prettify-symbols-alist'.  It adds support for macros formerly
> provided by textcomp package which are now part of LaTeX kernel.  I will
> prepare a format-patch once this change is accepted.

[...]

> +    ;; Text symbols formerly part of textcomp package:
> +    ("\\textdollar" . ?$) ; "0024
> +    ("\\textborn" . ?*) ; "002A
> +    ("\\textless" . ?<) ; "003C

Is there any point in adding the numerical code to all these lines?  And
if we want that, I think this should be two patches -- one that adds the
new symbols, and one that adds codes to the old lines, otherwise it's
difficult to say what's changed functionally.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Thu, 03 Mar 2022 16:34:39 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Is there any point in adding the numerical code to all these lines?

It's for reference only to show which character LaTeX will pick.  One
difference I found between the current implementation and my patch is
the entry for \textdied.  Current implementation is:

  character: ✝ (displayed as ✝) (codepoint 10013, #o23435, #x271d)
   to input: type "C-x 8 RET 271d" or "C-x 8 RET LATIN CROSS"

LaTeX does (and my change too):

  character: † (displayed as †) (codepoint 8224, #o20040, #x2020)
   to input: type "C-x 8 RET 2020" or "C-x 8 RET DAGGER"

One could now argue that the current implementation is better for
prettifying, but I would say to stick with LaTeX does to keep the
difference between final product and what you see in the editor low.
But that's only me.

> And if we want that, I think this should be two patches -- one that
> adds the new symbols,

I can provide a new patch and delete the code points, just let me know.

Best, Arash

Message #14 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Fri, 04 Mar 2022 16:37:15 +0100

Arash Esbati <arash <at> gnu.org> writes:

>> Is there any point in adding the numerical code to all these lines?
>
> It's for reference only to show which character LaTeX will pick.  One
> difference I found between the current implementation and my patch is
> the entry for \textdied.  Current implementation is:
>
>   character: ✝ (displayed as ✝) (codepoint 10013, #o23435, #x271d)
>    to input: type "C-x 8 RET 271d" or "C-x 8 RET LATIN CROSS"
>
> LaTeX does (and my change too):
>
>   character: † (displayed as †) (codepoint 8224, #o20040, #x2020)
>    to input: type "C-x 8 RET 2020" or "C-x 8 RET DAGGER"

Adding a comment noting that this is DAGGER might be appropriate for
that one, since it seems confusable.

>> And if we want that, I think this should be two patches -- one that
>> adds the new symbols,
>
> I can provide a new patch and delete the code points, just let me know.

Yes, please do.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Thu, 17 Mar 2022 11:24:28 +0100

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Arash Esbati <arash <at> gnu.org> writes:
>>
>> I can provide a new patch and delete the code points, just let me know.
>
> Yes, please do.  

Please find attached the next try.  Let me know if it's Ok and I push it
to Emacs master.

Best, Arash

[tex-prettify.diff (text/x-patch, attachment)]

Message #20 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Thu, 17 Mar 2022 11:32:35 +0100

Arash Esbati <arash <at> gnu.org> writes:

> Please find attached the next try.  Let me know if it's Ok and I push it
> to Emacs master.

Looks good to me; please go ahead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #23 received at 54233 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54233 <at> debbugs.gnu.org
Subject: Re: bug#54233: 29.0.50; [PATCH] Missing symbols in
 tex--prettify-symbols-alist
Date: Thu, 17 Mar 2022 11:51:35 +0100

close 54233 29.1
quit

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks good to me; please go ahead.

Thanks, pushed.  I'm closing this report.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.