GNU bug report logs - #53505
[PATCH] .dir-locals.el: Don't mess up indentation of prepend and append.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: bug#53505: closed (Re: bug#53505: [PATCH] .dir-locals.el: Don't
 mess up indentation of prepend and append.)
Date: Sat, 29 Jan 2022 07:52:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53505: [PATCH] .dir-locals.el: Don't mess up indentation of prepend and append.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53505 <at> debbugs.gnu.org.

-- 
53505: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53505
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53505-done <at> debbugs.gnu.org
Subject: Re: bug#53505: [PATCH] .dir-locals.el: Don't mess up indentation of
 prepend and append.
Date: Sat, 29 Jan 2022 08:51:10 +0100

Hi

Am Samstag, dem 29.01.2022 um 00:03 +0100 schrieb Ludovic Courtès:
> Hallo!
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:
> > It might not clash, but is its behaviour correct?  [...]
> 
> That looks wrong indeed.  Actually these two rules make no sense,
> right?  I don’t know what I was thinking about.
> 
> So I guess you can drop them, sorry for the noise!
Don't worry and thanks for confirming.  I've pushed this now.

Cheers

[Message part 3 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] .dir-locals.el: Don't mess up indentation of prepend and
 append.
Date: Mon, 24 Jan 2022 17:36:46 +0100

The current version appears to assume special values in the first and second
package, but it's either all lists (default append) or all package input
expressions (inside modify-inputs), which themselves are either packages
or a list consisting of a package and a string.

* .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-function 2))
and (eval . (put 'append 'scheme-indent-function 2)).
---
 .dir-locals.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.dir-locals.el b/.dir-locals.el
index 12a6f08739..0edf2a8d23 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -60,8 +60,6 @@
    ;; 'modify-inputs' and its keywords.
    (eval . (put 'modify-inputs 'scheme-indent-function 1))
    (eval . (put 'replace 'scheme-indent-function 1))
-   (eval . (put 'prepend 'scheme-indent-function 2))
-   (eval . (put 'append 'scheme-indent-function 2))
 
    ;; 'modify-phases' and its keywords.
    (eval . (put 'modify-phases 'scheme-indent-function 1))
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.