GNU bug report logs - #53505
[PATCH] .dir-locals.el: Don't mess up indentation of prepend and append.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53505 in the body.
You can then email your comments to 53505 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] .dir-locals.el: Don't mess up indentation of prepend and
 append.
Date: Mon, 24 Jan 2022 17:36:46 +0100

The current version appears to assume special values in the first and second
package, but it's either all lists (default append) or all package input
expressions (inside modify-inputs), which themselves are either packages
or a list consisting of a package and a string.

* .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-function 2))
and (eval . (put 'append 'scheme-indent-function 2)).
---
 .dir-locals.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.dir-locals.el b/.dir-locals.el
index 12a6f08739..0edf2a8d23 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -60,8 +60,6 @@
    ;; 'modify-inputs' and its keywords.
    (eval . (put 'modify-inputs 'scheme-indent-function 1))
    (eval . (put 'replace 'scheme-indent-function 1))
-   (eval . (put 'prepend 'scheme-indent-function 2))
-   (eval . (put 'append 'scheme-indent-function 2))
 
    ;; 'modify-phases' and its keywords.
    (eval . (put 'modify-phases 'scheme-indent-function 1))
-- 
2.34.0

Message #8 received at 53505 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 53505 <at> debbugs.gnu.org
Subject: Re: bug#53505: [PATCH] .dir-locals.el: Don't mess up indentation of
 prepend and append.
Date: Wed, 26 Jan 2022 12:24:15 +0100

Hi!

Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:

> The current version appears to assume special values in the first and second
> package, but it's either all lists (default append) or all package input
> expressions (inside modify-inputs), which themselves are either packages
> or a list consisting of a package and a string.
>
> * .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-function 2))
> and (eval . (put 'append 'scheme-indent-function 2)).

Yeah it’s been bothering me too.  :-)

We can keep ‘prepend’ though as it doesn’t clash with anything.

Otherwise LGTM,
Ludo’.

Message #11 received at 53505 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53505 <at> debbugs.gnu.org
Subject: Re: bug#53505: [PATCH] .dir-locals.el: Don't mess up indentation of
 prepend and append.
Date: Wed, 26 Jan 2022 20:26:21 +0100

Hi!

Am Mittwoch, dem 26.01.2022 um 12:24 +0100 schrieb Ludovic Courtès:
> Hi!
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:
> 
> > The current version appears to assume special values in the first
> > and second package, but it's either all lists (default append) or
> > all package input expressions (inside modify-inputs), which
> > themselves are either packages or a list consisting of a package
> > and a string.
> > 
> > * .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-
> > function 2))
> > and (eval . (put 'append 'scheme-indent-function 2)).
> 
> Yeah it’s been bothering me too.  :-)
> 
> We can keep ‘prepend’ though as it doesn’t clash with anything.
It might not clash, but is its behaviour correct?  IIRC, prepend and
append take a list of packages inside modify-inputs, so if I wanted to
add spam, ham, eggs, milk and butter to a python-package, I'd write
that as

(modify-inputs my-package
  (prepend python-spam
       python-ham
     python-eggs
     python-milk
     python-butter))

That doesn't seem right, now does it?

Message #14 received at 53505 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 53505 <at> debbugs.gnu.org
Subject: Re: [PATCH] .dir-locals.el: Don't mess up indentation of prepend
 and append.
Date: Wed, 26 Jan 2022 21:39:48 +0100

[Message part 1 (text/plain, inline)]

Lily, Ludo',

In fact the indentation rule for ‘prepend’ convinced me that I was 
holding it wrong the first time I tried it.  Perhaps I was missing 
a LIST call?  I had to convince myself I really wasn't.

What's the case in which the indent-by-2 rule is correct?  Trying 
to learn here.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 53505 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 53505 <at> debbugs.gnu.org
Subject: Re: bug#53505: [PATCH] .dir-locals.el: Don't mess up indentation of
 prepend and append.
Date: Sat, 29 Jan 2022 00:03:02 +0100

Hallo!

Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:

> Am Mittwoch, dem 26.01.2022 um 12:24 +0100 schrieb Ludovic Courtès:
>> Hi!
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:
>> 
>> > The current version appears to assume special values in the first
>> > and second package, but it's either all lists (default append) or
>> > all package input expressions (inside modify-inputs), which
>> > themselves are either packages or a list consisting of a package
>> > and a string.
>> > 
>> > * .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-
>> > function 2))
>> > and (eval . (put 'append 'scheme-indent-function 2)).
>> 
>> Yeah it’s been bothering me too.  :-)
>> 
>> We can keep ‘prepend’ though as it doesn’t clash with anything.
> It might not clash, but is its behaviour correct?  IIRC, prepend and
> append take a list of packages inside modify-inputs, so if I wanted to
> add spam, ham, eggs, milk and butter to a python-package, I'd write
> that as
>
> (modify-inputs my-package
>   (prepend python-spam
>        python-ham
>      python-eggs
>      python-milk
>      python-butter))
>
> That doesn't seem right, now does it?

That looks wrong indeed.  Actually these two rules make no sense, right?
I don’t know what I was thinking about.

So I guess you can drop them, sorry for the noise!

Ludo’.

Message #22 received at 53505-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53505-done <at> debbugs.gnu.org
Subject: Re: bug#53505: [PATCH] .dir-locals.el: Don't mess up indentation of
 prepend and append.
Date: Sat, 29 Jan 2022 08:51:10 +0100

Hi

Am Samstag, dem 29.01.2022 um 00:03 +0100 schrieb Ludovic Courtès:
> Hallo!
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:
> > It might not clash, but is its behaviour correct?  [...]
> 
> That looks wrong indeed.  Actually these two rules make no sense,
> right?  I don’t know what I was thinking about.
> 
> So I guess you can drop them, sorry for the noise!
Don't worry and thanks for confirming.  I've pushed this now.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.