GNU bug report logs - #51296
[PATCH] Add WebP format support

Previous Next

Full log

Message #47 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 21:39:55 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 21 Oct 2021 11:36:45 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> >> +      contents = (uint8_t*) SSDATA (specified_data);
> >
> > Space before '*' again.  Also, is the type cast really needed?  If
> > not, it is better to drop it.
> 
> Fixed the style issue.
> 
> The cast fixes this warning, so I kept it and added a comment saying
> "Casting avoids a GCC warning":
> 
> image.c: In function ‘webp_load’:
> image.c:8878:16: warning: pointer targets in assignment from ‘char *’
> to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness
> [-Wpointer-sign]
>  8878 |       contents = SSDATA (specified_data);
>       |                ^

And if you use SDATA instead of SSDATA?

Otherwise, I think this is good to go, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.