GNU bug report logs - #51296
[PATCH] Add WebP format support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51296 in the body.
You can then email your comments to 51296 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add WebP format support
Date: Tue, 19 Oct 2021 16:27:56 -0700

[Message part 1 (text/plain, inline)]

Severity: wishlist

WebP is an image format promoted by Google since 2010 with a promise of
decreased file sizes.  Adoption in web browsers have been slow, but in
2019, Firefox added support for it, and other browsers followed.[1]
Since then, this image format has become increasingly common on the web,
and is reported to be used on 2.5 % of all websites.[2]

I think it's important for Emacs to support it, both to support general
web development and to display images properly in e.g. EWW.  Given that
we no longer promote ImageMagick, I think adding our own support for it
is the way to go.

The attached patch does that, by using libwebp where it is available.[3]

Reviews are welcome, as usual.

Footnotes:
[1]  https://bugzilla.mozilla.org/show_bug.cgi?id=1294490

[2]  https://w3techs.com/technologies/details/im-webp

[3]  https://developers.google.com/speed/webp/download

[0001-Add-WebP-format-support.patch (text/x-diff, attachment)]

Message #8 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 10:42:49 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> WebP is an image format promoted by Google since 2010 with a promise of
> decreased file sizes.  Adoption in web browsers have been slow, but in
> 2019, Firefox added support for it, and other browsers followed.[1]
> Since then, this image format has become increasingly common on the web,
> and is reported to be used on 2.5 % of all websites.[2]

Yeah, it doesn't seem to be going away, so I think it makes sense to add
support for it in Emacs.  (Haven't tried the patch, though.)

> The attached patch does that, by using libwebp where it is available.[3]

[...]

> [3]  https://developers.google.com/speed/webp/download

libwebp seems to be available in Debian/bookwork, at least:

libwebp6/testing,now 0.6.1-2.1 amd64 [installed,automatic]

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 05:40:50 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> libwebp seems to be available in Debian/bookwork, at least:
>
> libwebp6/testing,now 0.6.1-2.1 amd64 [installed,automatic]

I think it should be available in any reasonably current distribution at
this point, see e.g.:

    https://src.fedoraproject.org/rpms/libwebp
    https://archlinux.org/packages/extra/x86_64/libwebp/
    https://guix.gnu.org/packages/libwebp-1.1.0/
    https://software.opensuse.org/package/libwebp

Looking at the dependencies in the various distributions, it seems to be
used by chromium and gimp (hard dependencies in Debian stable/bookworm),
but also e.g. ffmpeg and graphicsmagick.

I should also add that libwebp is BSD licensed.

Message #14 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 51296 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 06:02:09 -0700

Stefan Kangas <stefan <at> marxist.se> writes:

> Reviews are welcome, as usual.

Another thing that I forgot to add is that this is 100 % untested on
MS-Windows.  I made an attempt to add in the DLL-stuff based on pattern
recognition and guesswork, but it'd hardly be surprising if I messed up
somewhere.

Message #17 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 16:14:47 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 20 Oct 2021 06:02:09 -0700
> 
> Stefan Kangas <stefan <at> marxist.se> writes:
> 
> > Reviews are welcome, as usual.
> 
> Another thing that I forgot to add is that this is 100 % untested on
> MS-Windows.  I made an attempt to add in the DLL-stuff based on pattern
> recognition and guesswork, but it'd hardly be surprising if I messed up
> somewhere.

You missed the fact that the MW-Windows build loads image libraries
on-demand, when/if the library is first required.  That affects the
way we support these in configure.ac, and it also needs an addition to
dynamic-library-alist in w32-win.el.

It should be easy to add those nits (assuming the code works ;-)

Message #20 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 08:22:44 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> You missed the fact that the MW-Windows build loads image libraries
> on-demand, when/if the library is first required.  That affects the
> way we support these in configure.ac, and it also needs an addition to
> dynamic-library-alist in w32-win.el.
>
> It should be easy to add those nits (assuming the code works ;-)

I attempted to add the `dynamic-library-alist' part in the attached, and
I also added a NEWS item.  I suppose someone who actually knows
MS-Windows stuff and can test it should take a look.

[0001-Add-WebP-format-support.patch (text/x-diff, attachment)]

Message #23 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 19:35:17 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 20 Oct 2021 08:22:44 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> > You missed the fact that the MW-Windows build loads image libraries
> > on-demand, when/if the library is first required.  That affects the
> > way we support these in configure.ac, and it also needs an addition to
> > dynamic-library-alist in w32-win.el.
> >
> > It should be easy to add those nits (assuming the code works ;-)
> 
> I attempted to add the `dynamic-library-alist' part in the attached, and
> I also added a NEWS item.  I suppose someone who actually knows
> MS-Windows stuff and can test it should take a look.

Thanks.  If you install this when I'm awake, I can fix it in almost
real time.  For now, just a couple of comments based on reading the
patch:

> +HAVE_WEBP=no
> +if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${opsys}" = "mingw32"; then
> +   if test "${with_webp}" != "no"; then
> +      WEBP_REQUIRED=0.6.0
> +      WEBP_MODULE="libwebp >= $WEBP_REQUIRED"
> +
> +      EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE])
> +      AC_SUBST(WEBP_CFLAGS)
> +      AC_SUBST(WEBP_LIBS)
> +
> +      if test $HAVE_WEBP = yes; then
> +        AC_DEFINE(HAVE_WEBP, 1, [Define to 1 if using libwebp.])
> +        CFLAGS="$CFLAGS $WEBP_CFLAGS"
> +      fi
> +   fi
> +fi

This is sub-optimal: it causes the Windows build to link with -lwebp,
which then makes the binary _require_ to have libwebp DLL when Emacs
starts.  (Unlike on Posix platforms, Windows binaries linked with a
shared library insist on finding it at startup, because the Windows
dynamic linking functionality needs that to resolve all the entry
points.)  This would require people who download the prebuilt binaries
to also have the library installed, or else Emacs will refuse to
start, even if the user has no use for WebP images.  So we instead do
this (this example is for libpng):

  # mingw32 loads the library dynamically.
  if test "$opsys" = mingw32; then
    AC_CHECK_HEADER([png.h], [HAVE_PNG=yes])
  elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes" \
       || test "${HAVE_NS}" = "yes"; then
    EMACS_CHECK_MODULES([PNG], [libpng >= 1.0.0])
    if test $HAVE_PNG = yes; then
      LIBPNG=$PNG_LIBS

That is, for MS-Windows we only check for the header, because we need
that to compile the code which supports the image type.  But we don't
add -lFOO to the linker switches.  (If you wonder what is HAVE_W32
about, then it's for Cygwin builds that use native w32 GUI "toolkit"
instead of X; Cygwin builds are linked like on Unix, and don't load
the image libraries on demand.)

> --- a/lisp/term/w32-win.el
> +++ b/lisp/term/w32-win.el
> @@ -274,6 +274,7 @@ libgnutls-version
>  	     '(gif "libgif-6.dll" "giflib5.dll" "gif.dll")
>  	 '(gif "libgif-5.dll" "giflib4.dll" "libungif4.dll" "libungif.dll")))
>         '(svg "librsvg-2-2.dll")
> +       '(libwebp "libwebp.dll")

This requires some Internet search, because DLLs on Windows usually
have a numeric version indication in their names, as you see in the
other cases.  In this case, the name produced by current versions of
libwebp seems to be libwebp-7.dll, not just libwebp.dll.  But it's
probably a good idea to leave libwebp.dll as a fallback.  So this
should be

     '(libwebp "libwebp-7.dll" "libwebp.dll")

Message #26 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: stefan <at> marxist.se
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 20:13:02 +0300

> Date: Wed, 20 Oct 2021 19:35:17 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 51296 <at> debbugs.gnu.org
> 
> > +       '(libwebp "libwebp.dll")
> 
> This requires some Internet search, because DLLs on Windows usually
> have a numeric version indication in their names, as you see in the
> other cases.  In this case, the name produced by current versions of
> libwebp seems to be libwebp-7.dll, not just libwebp.dll.  But it's
> probably a good idea to leave libwebp.dll as a fallback.  So this
> should be
> 
>      '(libwebp "libwebp-7.dll" "libwebp.dll")

Btw, the Windows binaries available from the libwebp site don't seem
to include DLLs, only static libraries.  Caveat emptor!

Message #29 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 10:41:34 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Btw, the Windows binaries available from the libwebp site don't seem
> to include DLLs, only static libraries.  Caveat emptor!

Does this change anything with regards to the patch besides the things
you already mentioned?

Message #32 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 21:19:42 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 20 Oct 2021 10:41:34 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Btw, the Windows binaries available from the libwebp site don't seem
> > to include DLLs, only static libraries.  Caveat emptor!
> 
> Does this change anything with regards to the patch besides the things
> you already mentioned?

No, it just means that people shouldn't download the binaries from
there.  They were compiled with MSVC, so could depend on proprietary
libraries which are part of MSVC installation, anyway.

Message #35 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 14:02:29 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks.  If you install this when I'm awake, I can fix it in almost
> real time.

Excellent, thank you.

> This is sub-optimal: it causes the Windows build to link with -lwebp,
> which then makes the binary _require_ to have libwebp DLL when Emacs
> starts.  [...]

Thanks for that detailed explanation.  I believe this should be all
fixed in the attached.

>      '(libwebp "libwebp-7.dll" "libwebp.dll")

Also fixed.

[0001-Add-WebP-format-support.patch (text/x-diff, attachment)]

Message #38 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Wed, 20 Oct 2021 17:45:28 -0700

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefan <at> marxist.se> writes:

> Also fixed.

I spotted a typo, fixed in the attached patch.

[0001-Add-WebP-format-support.patch (text/x-diff, attachment)]

Message #41 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 11:19:44 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 20 Oct 2021 17:45:28 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> > Also fixed.
> 
> I spotted a typo, fixed in the attached patch.

Thanks, now only a few minor issues remain:

> +### mingw32 doesn't use -lwebp, since it loads the library dynamically.
> +HAVE_WEBP=no
> +if test "${with_webp}" != "no"; then
> +   if test "$opsys" = mingw32; then
> +      AC_CHECK_HEADER([webp/decode.h], [HAVE_WEBP=yes])
> +   elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes" \
> +         || test "${HAVE_NS}" = "yes"; then
> +      WEBP_REQUIRED=0.6.0
> +      WEBP_MODULE="libwebp >= $WEBP_REQUIRED"
> +
> +      EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE])
> +      AC_SUBST(WEBP_CFLAGS)
> +      AC_SUBST(WEBP_LIBS)
> +
> +      if test $HAVE_WEBP = yes; then
> +        AC_DEFINE(HAVE_WEBP, 1, [Define to 1 if using libwebp.])
> +        CFLAGS="$CFLAGS $WEBP_CFLAGS"
> +      fi
> +   fi
> +fi

That's OK, but I believe you should also add WEBP to the list of Emacs
configuration features around line 5885 in configure.ac, so that WebP
support could be reported by system-configuration-features.

> +DEF_DLL_FN (int, WebPGetInfo, (const uint8_t* data, size_t data_size, int* width, int* height));

Our style is to separate the '*' from the type, like this:

  DEF_DLL_FN (int, WebPGetInfo, (const uint8_t *, size_t, int *, int *));
                                              ^^             ^^     ^^
Also note that there's no need to use names of parameters in
prototypes, they just make the code longer, but don't add anything
useful.  So I removed them in the above.

> +static bool
> +init_webp_functions (void)
> +{
> +  HMODULE library;
> +
> +  if (!(library = w32_delayed_load (Qwebp)))
> +    return 0;
       ^^^^^^^^
"return false" is more consistent.

> +      contents = (uint8_t*) SSDATA (specified_data);

Space before '*' again.  Also, is the type cast really needed?  If
not, it is better to drop it.

> +  /* Validate the WebP image header.  */
> +  if (!WebPGetInfo (contents, size, NULL, NULL))
> +    {
> +      if (!NILP (specified_data))
> +	image_error ("Not a WebP file: `%s'", file);
> +      else
> +	image_error ("Invalid WebP data");

This last error message could IMO be more useful, if it said something
like "Non-WebP header in WebP image data".

> +	image_error ("Error when interpreting WebP data: `%s'", file);

Suggest to say "Error when interpreting WebP data from file `%s'"
instead, otherwise it may not be clear to the user what is that string
after the colon.

> +	image_error ("Error when interpreting WebP data");

I'd suggest "Error when interpreting WebP image data".

Message #44 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 11:36:45 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, now only a few minor issues remain:

All your comments should be fixed, see below for details.  I've also
attached an updated patch.  Thank you for reviewing.

> That's OK, but I believe you should also add WEBP to the list of Emacs
> configuration features around line 5885 in configure.ac, so that WebP
> support could be reported by system-configuration-features.

Ah, right.  Fixed.

> Our style is to separate the '*' from the type, like this:
>
>   DEF_DLL_FN (int, WebPGetInfo, (const uint8_t *, size_t, int *, int *));
>                                               ^^             ^^     ^^
> Also note that there's no need to use names of parameters in
> prototypes, they just make the code longer, but don't add anything
> useful.  So I removed them in the above.

Fixed.

>> +  if (!(library = w32_delayed_load (Qwebp)))
>> +    return 0;
>        ^^^^^^^^
> "return false" is more consistent.

Fixed.

>> +      contents = (uint8_t*) SSDATA (specified_data);
>
> Space before '*' again.  Also, is the type cast really needed?  If
> not, it is better to drop it.

Fixed the style issue.

The cast fixes this warning, so I kept it and added a comment saying
"Casting avoids a GCC warning":

image.c: In function ‘webp_load’:
image.c:8878:16: warning: pointer targets in assignment from ‘char *’
to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness
[-Wpointer-sign]
 8878 |       contents = SSDATA (specified_data);
      |                ^

>> +  /* Validate the WebP image header.  */
>> +  if (!WebPGetInfo (contents, size, NULL, NULL))
>> +    {
>> +      if (!NILP (specified_data))
>> +	image_error ("Not a WebP file: `%s'", file);
>> +      else
>> +	image_error ("Invalid WebP data");
>
> This last error message could IMO be more useful, if it said something
> like "Non-WebP header in WebP image data".

I went with: "Invalid header in WebP image data".

>> +	image_error ("Error when interpreting WebP data: `%s'", file);
>
> Suggest to say "Error when interpreting WebP data from file `%s'"
> instead, otherwise it may not be clear to the user what is that string
> after the colon.
>
>> +	image_error ("Error when interpreting WebP data");
>
> I'd suggest "Error when interpreting WebP image data".

Yes, that's better.  Fixed.

[0001-Add-WebP-format-support.patch (text/x-diff, attachment)]

Message #47 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 21:39:55 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 21 Oct 2021 11:36:45 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> >> +      contents = (uint8_t*) SSDATA (specified_data);
> >
> > Space before '*' again.  Also, is the type cast really needed?  If
> > not, it is better to drop it.
> 
> Fixed the style issue.
> 
> The cast fixes this warning, so I kept it and added a comment saying
> "Casting avoids a GCC warning":
> 
> image.c: In function ‘webp_load’:
> image.c:8878:16: warning: pointer targets in assignment from ‘char *’
> to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness
> [-Wpointer-sign]
>  8878 |       contents = SSDATA (specified_data);
>       |                ^

And if you use SDATA instead of SSDATA?

Otherwise, I think this is good to go, thanks.

Message #50 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 14:19:26 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> And if you use SDATA instead of SSDATA?

Yes, that fixed it.  I guess SSDATA is there specifically to avoid
casting warnings, but in this case only produced one...

> Otherwise, I think this is good to go, thanks.

Great!  If it's fine by you, I will push this to master tomorrow (or the
day after) at a time when you are typically online, just in case there
is any fallout on MS-Windows.

Message #53 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Fri, 22 Oct 2021 09:16:04 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 21 Oct 2021 14:19:26 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > And if you use SDATA instead of SSDATA?
> 
> Yes, that fixed it.  I guess SSDATA is there specifically to avoid
> casting warnings, but in this case only produced one...

Yes.  The original macro was SDATA, and we added SSDATA later, when
GCC started emitting these annoying warnings.

> > Otherwise, I think this is good to go, thanks.
> 
> Great!  If it's fine by you, I will push this to master tomorrow (or the
> day after) at a time when you are typically online, just in case there
> is any fallout on MS-Windows.

Please go ahead, and thanks.

Message #56 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Fri, 22 Oct 2021 02:03:22 -0700

close 51296 29.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

> Please go ahead, and thanks.

Now pushed to master (commit bc2a5c1127).

I'm closing this bug as fixed, but we can obviously continue discussing
any remaining issues here.

Message #61 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Fri, 22 Oct 2021 15:06:40 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Fri, 22 Oct 2021 02:03:22 -0700
> Cc: 51296 <at> debbugs.gnu.org
> 
> close 51296 29.1
> thanks
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Please go ahead, and thanks.
> 
> Now pushed to master (commit bc2a5c1127).

Thanks.  This has some issues, and currently won't work on MS-Windows.
I'm working on that.

Message #64 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: stefan <at> marxist.se
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Fri, 22 Oct 2021 15:47:41 +0300

> Date: Fri, 22 Oct 2021 15:06:40 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 51296 <at> debbugs.gnu.org
> 
> > Now pushed to master (commit bc2a5c1127).
> 
> Thanks.  This has some issues, and currently won't work on MS-Windows.
> I'm working on that.

Now done and installed.  WebP support should now work on MS-Windows.

Message #67 received at 51296 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51296 <at> debbugs.gnu.org
Subject: Re: bug#51296: [PATCH] Add WebP format support
Date: Fri, 22 Oct 2021 10:27:30 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

> Now done and installed.  WebP support should now work on MS-Windows.

Thank you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.