GNU bug report logs - #51295
28.0.60; [PATCH] Update ANSI colors in themes to use new faces

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51295 in the body.
You can then email your comments to 51295 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.60; [PATCH] Update ANSI colors in themes to use new faces
Date: Tue, 19 Oct 2021 16:18:18 -0700

[Message part 1 (text/plain, inline)]

In bug#50179, I added support for bright ANSI colors and changed the way 
the colors are defined to use faces instead of a vector of color values. 
However, I neglected to update the themes to take this into account. 
Attached is a patch that does this. Note: I only updated themes which 
defined `ansi-color-names-vector' (except for the Modus themes, which 
were already up-to-date).

For the most part, I just converted the definitions and added some 
hopefully-reasonable bright variants, but I did tweak the colors here 
and there to ensure 1) a reasonably-visible difference between normal 
and bright colors, and 2) that the color values roughly matched their 
names (mainly for wombat).

I can provide screenshots if it would help, but rainbow-mode on GNU ELPA 
should hopefully make it fairly easy to review the colors.

[0001-Convert-ANSI-color-definitions-in-themes-to-use-face.patch (text/plain, attachment)]

Message #8 received at 51295 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 51295 <at> debbugs.gnu.org
Subject: Re: bug#51295: 28.0.60; [PATCH] Update ANSI colors in themes to use
 new faces
Date: Wed, 20 Oct 2021 10:28:56 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

> For the most part, I just converted the definitions and added some
> hopefully-reasonable bright variants, but I did tweak the colors here
> and there to ensure 1) a reasonably-visible difference between normal
> and bright colors, and 2) that the color values roughly matched their
> names (mainly for wombat).

Looks good to me; pushed to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.