GNU bug report logs - #5012
avl-tree.el enhancements

Previous Next

Package: emacs;

Reported by: Toby Cubitt <toby-predictive-dated-1259366092.657383 <at> dr-qubit.org>

Date: Mon, 23 Nov 2009 00:00:06 UTC

Severity: wishlist

Tags: patch

Merged with 5015, 5016, 5021, 5024

Fixed in version 24.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5012 in the body.
You can then email your comments to 5012 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#5012; Package emacs. (Mon, 23 Nov 2009 00:00:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to Toby Cubitt <toby-predictive-dated-1259366092.657383 <at> dr-qubit.org>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 23 Nov 2009 00:00:08 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Toby Cubitt <tsc25 <at> cantab.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, bug-gnu-emacs <at> gnu.org
Subject: avl-tree.el enhancements
Date: Mon, 23 Nov 2009 00:01:23 +0000
[Message part 1 (text/plain, inline)]
Attached is a sequence of two patches for avl-tree.el, implementing the
enhancements to that library that I posted a while ago to the
gnu-emacs-sources list.

The first patch, avl-tree.el.1.diff, simplifies some of the avl-tree.el
functions, reducing code redundancy. These changes also make it natural
to add an optional argument to `avl-tree-map' specifying the order in
which to map over the tree.

The second patch, avl-tree.el.2.diff, contains the feature
enhancements. It adds optional arguments to a number of functions, and
adds a number of new functions. The new optional argument to
`avl-tree-member' allows it to distinguish a non-existence element from
an element of the tree with null data. The new optional argument to
`avl-tree-enter' allows data in the tree to be updated without having to
first search for it and then enter the new data (a factor of 2 difference
in efficiency). Similarly, the new optional argument to `avl-tree-delete'
allows data to be deleted if it satisfies some predicate (another factor
of 2 in efficiency). The patch also adds new mapping functions, and new
functions for accessing the tree elements as though they were a stack
(which for some purposes can be more efficient than mapping over the tree
of flattening it).

Note that, as the only changes to the existing function interfaces are
additional optional arguments, any code using avl-tree.el will remain
compatible with the modified version.

I've initiated the copyright paperwork process, so hopefully you should
have everything you need soon.

Toby Cubitt
[avl-tree.el.1.diff (text/plain, attachment)]
[avl-tree.el.2.diff (text/plain, attachment)]

Merged 5012 5015 5016 5021 5024. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Mon, 23 Nov 2009 17:20:04 GMT) Full text and rfc822 format available.

Severity set to 'wishlist' from 'normal' Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Mon, 23 Nov 2009 17:20:05 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#5012; Package emacs. (Mon, 23 Nov 2009 17:25:04 GMT) Full text and rfc822 format available.

Message #12 received at 5012 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5012 <at> debbugs.gnu.org
Cc: Toby Cubitt <tsc25 <at> cantab.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#5012: avl-tree.el enhancements
Date: Mon, 23 Nov 2009 12:16:42 -0500
Please stop cc'ing bug-gnu-emacs.
Instead, use 5012 <at> debbugs.gnu.org.
Otherwise every reply creates a new bug number.
To avoid this in future, use X-Debbugs-Cc rather than Cc when
first reporting a new bug.
Thanks.



Added tag(s) patch. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Tue, 24 Nov 2009 23:30:05 GMT) Full text and rfc822 format available.

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 23 Feb 2012 19:55:02 GMT) Full text and rfc822 format available.

Notification sent to Toby Cubitt <toby-predictive-dated-1259366092.657383 <at> dr-qubit.org>:
bug acknowledged by developer. (Thu, 23 Feb 2012 19:55:02 GMT) Full text and rfc822 format available.

Message #19 received at 5012-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5012-done <at> debbugs.gnu.org
Subject: Re: bug#5012: avl-tree.el enhancements
Date: Thu, 23 Feb 2012 14:51:33 -0500
Version: 24.1

Installed 2011-05-27.




Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 23 Feb 2012 19:55:02 GMT) Full text and rfc822 format available.

Notification sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
bug acknowledged by developer. (Thu, 23 Feb 2012 19:55:02 GMT) Full text and rfc822 format available.

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 23 Feb 2012 19:55:02 GMT) Full text and rfc822 format available.

Notification sent to Toby Cubitt <toby-dated-1259401082.6010d2 <at> dr-qubit.org>:
bug acknowledged by developer. (Thu, 23 Feb 2012 19:55:03 GMT) Full text and rfc822 format available.

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 23 Feb 2012 19:55:03 GMT) Full text and rfc822 format available.

Notification sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
bug acknowledged by developer. (Thu, 23 Feb 2012 19:55:03 GMT) Full text and rfc822 format available.

Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 23 Feb 2012 19:55:03 GMT) Full text and rfc822 format available.

Notification sent to Toby Cubitt <toby-predictive-dated-1259427171.f81182 <at> dr-qubit.org>:
bug acknowledged by developer. (Thu, 23 Feb 2012 19:55:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Mar 2012 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 13 years and 90 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.